Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.10] [Canvas] Fix elements not being updated properly when filter is changed on workpad (#81863) #82866

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

poffdeluxe
Copy link
Contributor

Backports the following commits to 7.10:

…ed on workpad (elastic#81863)

* Update renderer handlers when element is changed

* Update handlers before render

* Add canvas functional test for filters

* Update snapshot and remove log

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/canvas/canvas_plugin_src/renderers/filters/dropdown_filter/component/dropdown_filter.tsx
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
canvas 1.4MB 1.4MB -294.0B

page load bundle size

id before after diff
canvas 1013.8KB 1013.8KB +88.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit f205367 into elastic:7.10 Nov 11, 2020
@poffdeluxe poffdeluxe deleted the backport/7.10/pr-81863 branch November 11, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants