[ML] Adds functional tests for the index data visualizer card contents #83174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
qn895
reviewed
Nov 11, 2020
| @@ -51,6 +53,167 @@ export function MachineLearningDataVisualizerIndexBasedProvider({ | |||
| await testSubjects.existOrFail(`mlFieldDataCard ${fieldName} ${cardType}`); | |||
| }, | |||
|
|
|||
| async assertNonMetricCardContents(cardType: string, fieldName: string, exampleCount?: number) { | |||
| await testSubjects.existOrFail( | |||
There was a problem hiding this comment.
Since this assertion for mlFieldDataCardContent is used in multiple places I think it would be good to have its own function with fieldName and cardType as the arguments. Same for mlFieldDataCardDocCount and mlFieldDataCardCardinality.
There was a problem hiding this comment.
Done in 563f2a3
pheyos
reviewed
Nov 12, 2020
x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts
Outdated
Show resolved
Hide resolved
darnautov
approved these changes
Nov 12, 2020
| defaultMessage="Sample size (per shard): {wrappedValue}" | ||
| values={{ wrappedValue: <b>{v}</b> }} | ||
| /> | ||
| <div data-test-subj={`mlDataVisualizerShardSizeOption ${v}`}> |
There was a problem hiding this comment.
nit: I presume it should be span instead of div, just to make sure the element stays inline like FormattedMessage result element
There was a problem hiding this comment.
Switched to <span> in 563f2a3
|
Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️ |
pheyos
approved these changes
Nov 12, 2020
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Nov 13, 2020
elastic#83174) * [ML] Adds functional tests for the index data visualizer card contents * [ML] Fix translations * [ML] Fix type errors in permissions tests * [ML] Address comments from review
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 13, 2020
…o-node-details * 'master' of github.com:elastic/kibana: [ML] Adds functional tests for the index data visualizer card contents (elastic#83174)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 16, 2020
* master: Migrate `/translations` route to core (elastic#83280) [APM] Ensure APM jest script can run (elastic#83398) [Uptime] Monitor status alert use url as instance (elastic#81736) [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259) TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964) [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139) Skips Vega test skip flaky suite (elastic#79967) [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020) Added ability to fire actions when an alert instance is resolved (elastic#82799) [ML] Adds functional tests for the index data visualizer card contents (elastic#83174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds functional tests for the contents of the cards in the index-based data visualizer, plus a test that a change to the sample size (per shard) control results in a change to the displayed document count for one of the cards.
Additional tests added:
Also adds in formatting for the total document count field, so it is consistent with the display of document counts inside each of the cards.
Before:
After:
Checklist