Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Renaming saved object repair to sync #84311

Merged
merged 3 commits into from
Nov 30, 2020
Merged

[ML] Renaming saved object repair to sync #84311

merged 3 commits into from
Nov 30, 2020

Conversation

jgowdyelastic
Copy link
Member

User facing text and code renamed to "sync" or "synchronize"

image

Checklist

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features labels Nov 25, 2020
@jgowdyelastic jgowdyelastic self-assigned this Nov 25, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 25, 2020 10:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@droberts195 droberts195 changed the title [ML] Remaiming saved object repair to sync [ML] Renaming saved object repair to sync Nov 25, 2020
peteharverson
peteharverson approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

When testing this I noticed that I always seem to have an unmatched saved objects for data frame analytics jobs that I delete. Is this a known issue?

@peteharverson
Copy link
Contributor

Ignore my earlier comment! I remembered that we still need to implement the functionality for deleting job saved objects if the job isn't visible in any other spaces, as listed in #82415.

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.2MB 5.2MB -159.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peteharverson peteharverson merged commit 090359c into elastic:master Nov 30, 2020
@peteharverson peteharverson mentioned this pull request Nov 30, 2020
Merged
peteharverson pushed a commit to peteharverson/kibana that referenced this pull request Nov 30, 2020
@jgowdyelastic @kibanamachine @peteharverson
[ML] Renaming saved object repair to sync (elastic#84311)
bea9574 
* [ML] Remaiming saved object repair to sync

* removing 0 from sync lists

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
peteharverson added a commit that referenced this pull request Nov 30, 2020
@peteharverson @jgowdyelastic @kibanamachine
[ML] Renaming saved object repair to sync (#84311) (#84495)
a55f3e0 
* [ML] Remaiming saved object repair to sync

* removing 0 from sync lists

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 30, 2020
@phillipb
Merge branch 'add-metadata-to-node-details' of github.com:phillipb/ki…
6a491e8 
…bana into add-metadata-to-node-details

* 'add-metadata-to-node-details' of github.com:phillipb/kibana:
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  [ML] Renaming saved object repair to sync (elastic#84311)
  [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313)
  [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456)
  [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322)
  TSVB field list performance issue on using annotations (elastic#84407)
  [Security Solution] Exceptions Cypress tests (elastic#81759)
  [ML] Fix spaces job ID check (elastic#84404)
  [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgowdyelastic @elasticmachine @peteharverson @kibanamachine