Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Painless Lab] Update server to use new es-js client #88704

Merged
merged 5 commits into from
Jan 25, 2021
Merged

[Painless Lab] Update server to use new es-js client #88704

merged 5 commits into from
Jan 25, 2021

Conversation

alisonelizabeth
Copy link
Contributor

Part of #73973

This PR updates the Painless Lab app to use the new ES JS client. It also updates the handle_es_error util to allow the consumer to provide a custom error response.

How to test:

Verify there have been no regressions to Painless Lab.

  1. Navigate to Painless Lab in Dev Tools.
  2. Verify a valid Painless script produces correct result in the "Output" panel.
  3. Verify an invalid Painless script shows the error details in the "Output" panel.

@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Painless Lab Dev tool for learning Painless v7.12.0 8.0.0 labels Jan 19, 2021
This was referenced Jan 19, 2021
Closed
Closed
@alisonelizabeth alisonelizabeth marked this pull request as ready for review January 20, 2021 15:13
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner January 20, 2021 15:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@wylieconlon wylieconlon added v8.0.0 and removed 8.0.0 labels Jan 20, 2021
@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alisonelizabeth , thanks a lot for updating painless lab to the new client! I tested locally and haven't noticed any regressions, code LGTM. Appreciate new API tests too 👍

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit edb5e35 into elastic:master Jan 25, 2021
@alisonelizabeth alisonelizabeth deleted the es_client_migration/painless_lab branch January 25, 2021 18:26
@alisonelizabeth alisonelizabeth mentioned this pull request Jan 25, 2021
Merged
alisonelizabeth added a commit that referenced this pull request Jan 26, 2021
@alisonelizabeth
[Painless Lab] Update server to use new es-js client (#88704) (#89206)
222d607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
Feature:Painless Lab Dev tool for learning Painless release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisonelizabeth @elasticmachine @kibanamachine @yuliacech @wylieconlon