Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Profiler] Migrate server to new es-js client #88725

Merged
merged 3 commits into from
Jan 25, 2021
Merged

[Search Profiler] Migrate server to new es-js client #88725

merged 3 commits into from
Jan 25, 2021

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Jan 19, 2021 •
edited
Loading

Part of #73973

This PR migrates Search Profiler to use the new ES JS client and adds API integration tests.

How to test:

Verify there have been no regressions to Search Profiler.

  1. Navigate to Search Profiler in Dev Tools.
  2. Verify the default configuration yields results in the "Query Profile" panel.
  3. Verify an invalid configuration (e.g., specifying an index that does not exist) shows an error notification and no results in the "Query Profile" panel.

@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Search Profiler v7.12.0 8.0.0 labels Jan 19, 2021
This was referenced Jan 19, 2021
Closed
Closed
@alisonelizabeth alisonelizabeth marked this pull request as ready for review January 20, 2021 15:15
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner January 20, 2021 15:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@wylieconlon wylieconlon added v8.0.0 and removed 8.0.0 labels Jan 20, 2021
@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alisonelizabeth , great job with the js client update! Didn't find any regressions in search profiler and code changes + new API tests LGTM 👍

@alisonelizabeth alisonelizabeth merged commit 43db7e3 into elastic:master Jan 25, 2021
@alisonelizabeth alisonelizabeth deleted the es_client_migration/searchprofiler branch January 25, 2021 16:28
@alisonelizabeth alisonelizabeth mentioned this pull request Jan 25, 2021
Merged
alisonelizabeth added a commit that referenced this pull request Jan 25, 2021
@alisonelizabeth
[Search Profiler] Migrate server to new es-js client (#88725) (#89175)
9f6e555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
Feature:Search Profiler release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisonelizabeth @elasticmachine @kibanamachine @yuliacech @wylieconlon