Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round start and end values #89030

Merged
merged 13 commits into from
Feb 2, 2021
Merged

Round start and end values #89030

merged 13 commits into from
Feb 2, 2021

Commits on Jan 21, 2021

  1. Round start and end values

    When getting the start and end times, use the d3 time scale `ticks` function to round the start and end times.
    
    Example from a query:
    
    Before:
    
    ```json
    {
              "range": {
                "@timestamp": {
                  "gte": 1611262874814,
                  "lte": 1611263774814,
                  "format": "epoch_millis"
                }
              }
            },
    ```
    
    After:
    
    ```json
    {
              "range": {
                "@timestamp": {
                  "gte": 1611263040000,
                  "lte": 1611263880000,
                  "format": "epoch_millis"
                }
              }
            },
    ```
    
    The `ticks` function makes it so the amount of rounding is proportional to the size of the time range, so shorter time ranges will be rounded less.
    
    Also fix a bug where invalid ranges in the query string were not handled correctly.
    
    Fixes elastic#84530.
    smith committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    a83ebd2 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. fixes

    smith committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    0c6021d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a9635d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. test fix

    smith committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    ba1a4b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c8556f View commit details
    Browse the repository at this point in the history
  3. add test

    smith committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    11dec6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b448d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. range id and more tests

    smith committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    f7394c6 View commit details
    Browse the repository at this point in the history
  2. fix test

    smith committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    f10a3fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7af8a39 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Configuration menu
    Copy the full SHA
    874f943 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Don't expose increment

    smith committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    378c08f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5367efa View commit details
    Browse the repository at this point in the history