Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] chore(NA): introduce new yarn kbn reset command to support bazel workflow (#89597) #90244

Merged
merged 4 commits into from
Feb 4, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Feb 3, 2021

Backports the following commits to 7.x:

…flow (elastic#89597)

* chore(NA): introduce new yarn kbn destroy command to support bazel workflow

* chore(NA): update wording for new kbn pm changes

* chore(NA): update .bazelrc.common

Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* chore(NA): update .bazelrc

Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* chore(NA): update packages/kbn-pm/src/commands/clean.ts

Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* chore(NA): update packages/kbn-pm/src/commands/destroy.ts

Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* chore(NA): update packages/kbn-pm/src/commands/clean.ts

Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* chore(NA): update packages/kbn-pm/src/commands/destroy.ts

Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* chore(NA): rename destroy command into reset

* chore(NA): update packages/kbn-pm/src/commands/clean.ts

Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* chore(NA): restore old behaviour on kbn clean

* chore(NA): update reset command to delete bazel caches on disk

* chore(NA): update packages/kbn-pm/src/commands/clean.ts

Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* chore(NA): update prefix to match bazel defined one for cache settings

* chore(NA): update kbn pm dist file

* chore(NA): update kbn pm dist

* chore(NA): update gitignore

* chore(NA): add new ignore files after changed bazel aggregated folder

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
# Conflicts:
#	packages/kbn-pm/dist/index.js
@mistic mistic added the backport label Feb 3, 2021
@mistic
Copy link
Member Author

mistic commented Feb 4, 2021

Merging this time before the CI complete as all the steps related to the code changes passed

@mistic mistic merged commit 1c6adb4 into elastic:7.x Feb 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 919.6KB 919.5KB -144.0B
apm 5.2MB 5.2MB -36.0B
canvas 1.4MB 1.4MB -1.1KB
dashboard 161.1KB 160.9KB -288.0B
dataEnhanced 151.0KB 150.8KB -144.0B
discover 415.7KB 413.4KB -2.3KB
enterpriseSearch 1.8MB 1.8MB -4.5KB
fleet 752.2KB 752.1KB -144.0B
graph 1.2MB 1.2MB -144.0B
home 182.7KB 182.5KB -144.0B
indexLifecycleManagement 232.6KB 231.9KB -720.0B
indexManagement 1.4MB 1.4MB -432.0B
indexPatternManagement 559.1KB 558.5KB -576.0B
infra 1.9MB 1.9MB -144.0B
ingestPipelines 724.7KB 723.3KB -1.4KB
inputControlVis 88.7KB 88.4KB -288.0B
kibanaLegacy 147.1KB 146.9KB -144.0B
kibanaReact 349.2KB 348.9KB -288.0B
lens 877.5KB 873.7KB -3.8KB
management 22.5KB 22.2KB -288.0B
maps 2.6MB 2.6MB -180.0B
mapsLegacy 713.7KB 713.6KB -108.0B
ml 6.6MB 6.6MB -2.1KB
monitoring 798.5KB 795.7KB -2.8KB
observability 187.9KB 187.6KB -288.0B
regionMap 285.0KB 284.9KB -144.0B
remoteClusters 176.1KB 175.9KB -144.0B
rollup 245.5KB 245.4KB -144.0B
savedObjectsManagement 163.9KB 163.7KB -144.0B
savedObjectsTagging 83.1KB 82.9KB -288.0B
security 725.6KB 724.2KB -1.4KB
spaces 41.6KB 41.2KB -432.0B
stackAlerts 681.6KB 681.5KB -144.0B
tileMap 288.1KB 288.0KB -144.0B
timelion 376.9KB 376.7KB -144.0B
triggersActionsUi 1.4MB 1.4MB -3.4KB
visDefaultEditor 246.3KB 246.2KB -144.0B
visTypeMarkdown 12.9KB 12.8KB -144.0B
visTypeMetric 19.3KB 19.2KB -144.0B
visTypeTable 121.1KB 120.8KB -288.0B
visTypeTagcloud 279.7KB 279.5KB -144.0B
visTypeTimelion 76.4KB 76.2KB -288.0B
visTypeVega 2.5MB 2.5MB -576.0B
visTypeVislib 622.2KB 622.1KB -144.0B
visTypeXy 127.4KB 127.1KB -288.0B
visualizations 57.2KB 56.9KB -288.0B
visualize 99.0KB 98.6KB -432.0B
total -31.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 160.1KB 159.8KB -288.0B
console 26.8KB 26.7KB -144.0B
core 466.3KB 465.8KB -576.0B
dashboard 295.5KB 295.4KB -72.0B
data 801.0KB 800.8KB -144.0B
devTools 18.2KB 18.1KB -144.0B
embeddable 166.8KB 166.7KB -144.0B
esUiShared 217.2KB 217.0KB -144.0B
expressions 165.8KB 165.7KB -144.0B
globalSearchBar 48.6KB 48.5KB -144.0B
indexManagement 43.9KB 43.7KB -144.0B
indexPatternManagement 70.0KB 69.8KB -144.0B
inspector 44.3KB 44.1KB -288.0B
kibanaLegacy 82.4KB 82.3KB -144.0B
kibanaOverview 45.2KB 45.0KB -144.0B
kibanaReact 119.9KB 119.4KB -576.0B
licenseManagement 19.7KB 19.6KB -144.0B
maps 138.6KB 138.4KB -144.0B
mapsLegacy 79.1KB 79.0KB -144.0B
navigation 19.4KB 19.3KB -144.0B
painlessLab 22.3KB 22.2KB -144.0B
presentationUtil 26.0KB 25.9KB -144.0B
savedObjects 56.2KB 56.0KB -144.0B
searchprofiler 45.9KB 45.7KB -144.0B
security 131.1KB 130.9KB -144.0B
share 73.3KB 73.2KB -144.0B
snapshotRestore 60.1KB 60.0KB -144.0B
spaces 233.0KB 231.3KB -1.7KB
transform 23.6KB 23.5KB -144.0B
triggersActionsUi 144.0KB 143.8KB -144.0B
uiActionsEnhanced 226.6KB 226.3KB -288.0B
upgradeAssistant 33.6KB 33.4KB -144.0B
visTypeTimeseries 126.9KB 126.7KB -144.0B
visualizations 113.9KB 113.8KB -144.0B
watcher 24.4KB 24.2KB -144.0B
total -7.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants