[Time to Visualize] Stay in Edit Mode After Dashboard Quicksave #91729
Conversation
ThomThomson
added
release_note:enhancement
Feature:Dashboard
ThomThomson
force-pushed
the
feature/quickSaveStayInEditMode
branch
from
0eb093a
to
9e71818
Compare
ThomThomson
force-pushed
the
feature/quickSaveStayInEditMode
branch
from
9e71818
to
0ac10bc
Compare
There was a problem hiding this comment.
LGTM 👍 I tested it out locally and staying in edit mode after quick saving makes a lot of sense. I've just got a couple pieces of feedback.
Can we set initialFocus on this return modal to one of the buttons? Maybe Cancel or Keep changes?
It also might be nice to disable the Save button when there aren't any unsaved changes.
|
@elasticmachine merge upstream |
…son/kibana into feature/quickSaveStayInEditMode
|
I was able to disable the quickSave button when there are no active changes, good call! I have been working on adding an There are a number of places where this is used, that could do with an |
…SaveStayInEditMode
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…tic#91729) * Make quicksave function stay in edit mode
…tic#91729) * Make quicksave function stay in edit mode
…) (#92053) * Make quicksave function stay in edit mode
…) (#92054) * Make quicksave function stay in edit mode
…ndition-for-hiding-recommded-allocation * 'master' of github.com:elastic/kibana: (117 commits) [coverage] ingest data in parallel (elastic#92074) [Lens] Drag and drop performance improvements (elastic#91641) A few more environment uiFilters fixes (elastic#92044) Enabling Uptime and Dashboard a11y test (elastic#91017) [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041) [Security Solution] [Detections] add overflow-wrap for description (elastic#91945) [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952) Skip flaky apm test elastic#91673 (elastic#92065) [docker] Default server.name to hostname (elastic#90799) Use documentation link service for snapshot restore (elastic#91596) [Security Solution] Clearing up all jest errors and warnings (elastic#91740) Add `@kbn/analytics` to UI Shared Deps (elastic#91810) [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920) [Security Solution] Adds cypress-pipe (elastic#91550) [ML] Fix event rate chart annotation position (elastic#91899) [APM] Break down error table api removing the sparklines (elastic#89138) docs: update dependencies table bug (elastic#91964) [Time to Visualize] Stay in Edit Mode After Dashboard Quicksave (elastic#91729) Unskip Search Sessions Management UI test (elastic#90110) [Fleet] Handle long text in agent details page (elastic#91776) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx # x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx
Summary
Changes the dashboard quicksave function to keep the user in edit mode instead of booting them out.
This also necessitated a loading state on the quick save button, and the disabling of the other buttons on the top nav while the dashboard is being saved.
Additionally, the
Cancelbutton has been renamed toReturnto better reflect its new usage to return to view mode after saving the dashboard. The confirm modal when the user has active changes has also been changed.Checklist
Delete any items that are not applicable to this PR.
For maintainers