Index pattern management - use new es client instead of legacy #95293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
added
v8.0.0
v7.13.0
Feature:Kibana Management
mattkime
changed the title
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
lukasolson
reviewed
Mar 24, 2021
Comment on lines
37
to
42
| const { body } = await context.core.elasticsearch.client.asCurrentUser.transport.request({ | ||
| method: 'GET', | ||
| path: `/_resolve/index/${encodeURIComponent(req.params.query)}${ | ||
| queryString ? '?' + new URLSearchParams(queryString).toString() : '' | ||
| }`, | ||
| }); |
There was a problem hiding this comment.
Does this work?
Suggested change
| const { body } = await context.core.elasticsearch.client.asCurrentUser.transport.request({ | |
| method: 'GET', | |
| path: `/_resolve/index/${encodeURIComponent(req.params.query)}${ | |
| queryString ? '?' + new URLSearchParams(queryString).toString() : '' | |
| }`, | |
| }); | |
| const { body } = await context.core.elasticsearch.client.asCurrentUser.resolveIndex({ | |
| expand_wildcards: req.query.expand_wildcards | |
| }); |
There was a problem hiding this comment.
not quite, but I did figure it out, thanks
💛 Build succeeded, but was flaky
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Mar 25, 2021
…ic#95293) * use new es client instead of legacy * use resolve api on client
mattkime
added a commit
that referenced
this pull request
Mar 25, 2021
… (#95467) * use new es client instead of legacy * use resolve api on client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use new ES client instead of legacy client for index pattern management.
addresses #83910