Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/test] switch to @elastic/elasticsearch #95443

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 25, 2021

Part of #83910

Switches the esClient exposed by createLegacyEsTestCluster() to be the modern @elastic/elasticsearch client. I've traced the uses of this function and it seems like there is only one place that is using the getCallCluster() helper now, and it's only passing basic args to this function, so I don't expect this update to have much impact as this is a legacy helper.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 25, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger marked this pull request as ready for review March 25, 2021 19:42
@spalger spalger requested a review from a team as a code owner March 25, 2021 19:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger enabled auto-merge (squash) March 25, 2021 19:42
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 25, 2021
@spalger spalger merged commit dd10c8b into elastic:master Mar 25, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 25, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #95468

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 25, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
@spalger spalger deleted the remove/kbn-test-legacy-es-usage branch August 2, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants