Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Tinymath to use peggy instead of pegjs #97906

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Switch Tinymath to use peggy instead of pegjs #97906

merged 1 commit into from
Apr 22, 2021

Conversation

wylieconlon
Copy link
Contributor

We are migrating all pegjs usage as the previous library has stopped being maintained. See discussion #97504 for more context.

As the new library is backwards compatible, this should be minimal impact.

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Apr 21, 2021
@wylieconlon wylieconlon requested review from lukeelmers, mistic and a team April 21, 2021 20:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

mistic
mistic reviewed Apr 21, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the old library or is still used elsewhere?

@wylieconlon
Copy link
Contributor Author

@mistic This library is used in a few other places in Kibana. I am working on a separate PR which updates all of them at once, but I think this PR is lower risk.

@wylieconlon wylieconlon mentioned this pull request Apr 21, 2021
Closed
mistic
mistic approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build file changes LGTM

@mistic
Copy link
Member

mistic commented Apr 21, 2021

Btw @wylieconlon congrats on the initiative to update the Bazel build file on your own 😄

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.2MB 1.2MB -134.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 193.0KB 192.9KB -134.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lukeelmers
lukeelmers approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for investigating this. Glad it's an easy update

flash1293
flash1293 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and tinymath in TSVB still works, LGTM

@wylieconlon wylieconlon added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 22, 2021
@wylieconlon wylieconlon merged commit d25bd68 into elastic:master Apr 22, 2021
@wylieconlon wylieconlon deleted the tinymath-migrate-peggy branch April 22, 2021 16:01
@kibanamachine kibanamachine mentioned this pull request Apr 22, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 22, 2021
@kibanamachine
Switch Tinymath to use peggy instead of pegjs (elastic#97906)
5efb7e6
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 22, 2021
@kibanamachine
Switch Tinymath to use peggy instead of pegjs (#97906) (#98048)
5b542f3 
Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
@madirey
Switch Tinymath to use peggy instead of pegjs (elastic#97906)
bf673b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wylieconlon @elasticmachine @mistic @kibanamachine @flash1293 @lukeelmers