Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rollups] remove use of custom cluster client #99623

Merged
merged 1 commit into from
May 10, 2021
Merged

[Rollups] remove use of custom cluster client #99623

merged 1 commit into from
May 10, 2021

Conversation

alisonelizabeth
Copy link
Contributor

This PR removes some leftover legacy code from the es-js client migration.

Follow-up to #95926.

@alisonelizabeth alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Rollups v7.14.0 labels May 10, 2021
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner May 10, 2021 12:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

yuliacech
yuliacech approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, @alisonelizabeth! Thanks a lot for completing this migration 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
rollup 2 0 -2
total -75

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 5f618da into elastic:master May 10, 2021
@alisonelizabeth alisonelizabeth deleted the rollups/es-client-migration branch May 10, 2021 14:19
@alisonelizabeth alisonelizabeth mentioned this pull request May 10, 2021
Merged
alisonelizabeth added a commit that referenced this pull request May 10, 2021
@alisonelizabeth
[Rollups] remove use of custom cluster client (#99623) (#99640)
54292b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisonelizabeth @elasticmachine @kibanamachine @yuliacech