Removed SimpleCov configuration to move it to the logstash repo #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
reviewed
Jan 15, 2024
jsvd
approved these changes
Jan 15, 2024
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
SimpleCovconfiguration to separate it from other settings and its configuration granular.The
SimpleCovneeds to be stared before any application code is running. The rest of the settings in thespec_helper.rbdidn't allow to use it before the logstash module is imported and causes a circular dependencyThe
SimpleCovinitalisation will be moved to the spec/spec_helper.rbRelates: https://github.com/elastic/ingest-dev/issues/2408