Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docs for managed agent on k8s #799

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Remove docs for managed agent on k8s #799

merged 1 commit into from
Jun 24, 2021

Conversation

ChrsMark
Copy link
Member

This PR removes section for managed elastic-agent on k8s since we don't currently officially support it.
K8s manifests are also being removed: elastic/beats#26368

@ChrsMark ChrsMark requested a review from a team as a code owner June 18, 2021 12:06
@ChrsMark ChrsMark mentioned this pull request Jun 18, 2021
Merged
@ChrsMark ChrsMark force-pushed the remove_managed_agent_k8s_docs branch from 5142ff5 to 03630b1 Compare June 18, 2021 12:31
@apmmachine
Copy link
Contributor

apmmachine commented Jun 18, 2021 •
edited
Loading

A documentation preview will be available soon:

@ruflin
Copy link
Member

ruflin commented Jun 18, 2021

I wonder if we should fully remove it or instead mainly remove the links to the manifest files and mention that it is not fully supported yet. But we have already questions on discuss and users will run it on k8s, so some guidance would be good.

@ChrsMark
Copy link
Member Author

@ruflin I think that providing guidance without an actual manifest would be incomplete. Also I have not run the case yet so I'm not sure what kind of guidance we could provide here.

We can prioritise the work for elastic/beats#25237 even in a primitive stage so as to have something complete soon. We also need this for ourselves when we test k8s integration/package manually in managed mode.

This was referenced Jun 18, 2021
Merged
Merged
@ruflin
Copy link
Member

ruflin commented Jun 18, 2021

SGTM

@dedemorton
Copy link
Contributor

Can we just remove this from the documentation build rather than deleting the file completely?

To do that, you just need to comment out lines 19 and 34

* <<running-on-kubernetes>>
...

include::running-on-kubernetes.asciidoc[leveloffset=+1]

If you think it's better to remove the file completely, then make sure you also remove these lines ^^ to fix the doc build.

@ChrsMark
Hide docs for mamanaged agent on k8s
245bd37 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the remove_managed_agent_k8s_docs branch from 03630b1 to 245bd37 Compare June 22, 2021 07:04
@ChrsMark
Copy link
Member Author

@dedemorton what you proposed sounds better so I applied your approach, thanks!

@ChrsMark
Copy link
Member Author

@dedemorton can we have this in soon since the manifests have already been removed?

dedemorton
dedemorton approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry about the delay. I fell down a TLS rabbit hole.

@dedemorton
Copy link
Contributor

I'm going to take the liberty of merging and backporting this.

@dedemorton dedemorton merged commit 2c56112 into elastic:master Jun 24, 2021
dedemorton pushed a commit to dedemorton/observability-docs that referenced this pull request Jun 24, 2021
@ChrsMark @dedemorton
Hide docs for mamanaged agent on k8s (elastic#799)
953ad87 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@dedemorton dedemorton mentioned this pull request Jun 24, 2021
Merged
dedemorton pushed a commit to dedemorton/observability-docs that referenced this pull request Jun 24, 2021
@ChrsMark @dedemorton
Hide docs for mamanaged agent on k8s (elastic#799)
e90222e 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@dedemorton dedemorton mentioned this pull request Jun 24, 2021
Merged
dedemorton added a commit that referenced this pull request Jun 24, 2021
@dedemorton @ChrsMark
Hide docs for mamanaged agent on k8s (#799) (#813)
265651f 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
dedemorton added a commit that referenced this pull request Jun 24, 2021
@dedemorton @ChrsMark
Hide docs for mamanaged agent on k8s (#799) (#814)
56d0038 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark mentioned this pull request Jul 1, 2021
Merged
6 tasks
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
@ChrsMark
Hide docs for mamanaged agent on k8s (elastic#799)
10901e6 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedemorton dedemorton dedemorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrsMark @apmmachine @ruflin @dedemorton