Update base reporter to emit screenshot as .jpg instead of json format #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
changed the title
There was a problem hiding this comment.
We discussed offline, the plan is to come up with these
- Test Result Interface output with attachments or similar API to get these screenshots
- Writing to
.syntheticsby default to be in safer side for permission model inside HB - Enhance the reporters to work on that testoutput.
- Allow overriding the path for emitting the output.
|
Closing in favor of #878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update base reporter to omit screenshot as .jpg instead of json format !!