fix: "Can't reconcile two non-macho files" due to new "PreGyp Copy" functionality in electron/rebuild integration #7519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa92d64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sandeep1995
reviewed
Apr 4, 2023
| log.info({ arch, version: frameworkInfo.version, appDir }, "executing @electron/rebuild") | ||
| const rootPath = await searchModule.getProjectRootPath(appDir) | ||
| const options: electronRebuild.RebuildOptions = { | ||
| buildPath: appDir, | ||
| electronVersion: frameworkInfo.version, | ||
| arch, | ||
| debug: log.isDebugEnabled, | ||
| arch: Arch[arch], | ||
| projectRootPath: rootPath, |
There was a problem hiding this comment.
Can you also add a different cachePath argument for different arch?
https://github.com/electron/rebuild/blob/main/src/types.ts#L10
There was a problem hiding this comment.
What for? Why can't the default cache be used?
…ebuild metadata and disable its pregyp cache
…r universal builds with native module (node-mac-permissions in this case)
…ate test snapshot
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7512 7512