Add in-app camera #6763

p1gp1g · 2022-08-07T13:42:38Z

Type of change

Feature
Bugfix
Technical
Other :

Content

This PR add a built-in / in-app camera to element as a lab feature. If the feature is not enable, it adds a button to attachment list to open the native camera for video.

Motivation and context

Currently, users have to choose between :

choosing a default behavior for the camera (photo or video)
or setting a default to one type.

That means, it adds clicks to take a photo/video or users won't change media type (it requires to go to settings to change the default behavior).

This fixes #1389, #2224, #3331, #1623 and maybe others.

Screenshots / GIFs

Outdated screenshots

The camera view before recording a video

The camera view while recording a video

The camera view before taking a photo

Only one attachment button to open a camera when the feature is enabled

2 attachment buttons to open a camera when the feature is disabled : one for a picture, one for a video

Tested devices

Physical
Emulator
OS version(s): Android 11

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

bmarty · 2022-08-16T15:07:05Z

Thanks for the PR.
@onurays can you review it please? I think you already worked on this part previously.

DoM1niC · 2022-08-24T18:03:02Z

works fine in my Fork!
But two things here, when I send pictures in Landscape the orientation is wrong and in Video mode the light is missing :( @p1gp1g

DoM1niC · 2022-08-26T15:33:30Z

The fragment removal (2b5920e) brick the AttachmentsCameraFragment @p1gp1g

p1gp1g · 2022-08-26T15:53:28Z

The fragment removal (2b5920e) brick the AttachmentsCameraFragment @p1gp1g

Thanks, it should be easy to fix. I'll check that when I can

Use VectorCameraOutput

Signed-off-by: sim <git@sgougeon.fr>

p1gp1g · 2022-08-27T14:23:40Z

Rebased (& fix the fragment)

p1gp1g · 2022-08-27T15:13:29Z

@DoM1niC : Here is the orientation support :)

p1gp1g · 2022-08-29T20:49:24Z

I think it looks OK now, so it is ready for review :)

onurays · 2022-09-05T12:34:53Z

Thanks for the PR! I have some UX-related remarks:

I am a little bit surprised when the app suddenly requests audio recording permission. My intention was just to take a photo.
In landscape mode, the orientation of icons is wrong (90 degrees rotated).
When I want to record a video camera and video icons are switching their positions. This seems not like a common UX for me.
While recording a video I expected to see a timer.

We need a design review before the code review. @gaelledel can you or someone else in the team have a look (I can send you an apk if needed).

p1gp1g · 2022-09-05T18:03:59Z

Thanks for the review !

1. I am a little bit surprised when the app suddenly requests audio recording permission. My intention was just to take a photo.

That's needed for the video record, I guess you already gave the authorization for the camera so you have received the single last request. We can change the behavior to ask for this permission only once the user try to record a video.

2. In landscape mode, the orientation of icons is wrong (90 degrees rotated).

Can you give a screenshot of it ? It will help to see what's wrong. There was an issue with the orientationListener being enabled onCreate instead of onStart, it was probably because of that.

3. When I want to record a video camera and video icons are switching their positions. This seems not like a common UX for me.

The UX is inspired from Open Camera. We can change for another one (edit: cf note behind)

4. While recording a video I expected to see a timer.

Good idea, and done :)

Edit: Thanks to a long delay for my train, I've implement another UX : photo on click and video on longclick + flash for video,
I m posting screenshots later

Start recording a video onLongClick

p1gp1g · 2022-09-06T07:16:17Z

Here are the screenshots with the new UX

Outdated screenshots

Edit: Outdated screenshots, see first post for the last screenshots.

kojid0 · 2022-09-06T08:59:49Z

Would it be possible to add a button to switch the front/back camera?
Like here, from Telegram. WhatsApp has a similar icon.

p1gp1g · 2022-09-06T09:12:49Z

Would it be possible to add a button to switch the front/back camera? Like here, from Telegram. WhatsApp has a similar icon.

That's the purpose of this button:

We may change to another icon if it is not obvious

kojid0 · 2022-09-06T09:23:03Z

Oh, thanks for the explanation. I thought it was for video recording but I just looked closer and saw the arrow 😄.
I suggest to add "Tap for photo, hold for video" in order to make users understand that there is a "hidden" video record feature.

Use simpleActivityWaitingView, stop camera preview Remove unused executer

p1gp1g · 2022-09-12T21:09:43Z

I have updated the screenshots on the first post

These changes are not directly related to an inApp Camera. This reverts commit 51b905f. This reverts some change in 9945231.

DoM1niC · 2022-09-29T15:44:59Z

The Portrait and Landscaping is wrong here after Capture

p1gp1g · 2022-09-29T15:58:29Z

The Portrait and Landscaping is wrong here after Capture <screenshot>

Does it happen often/Do you have instruction to reproduce ? I don't have this version installed anymore right now

DoM1niC · 2022-10-01T09:34:36Z

The Portrait and Landscaping is wrong here after Capture

Does it happen often/Do you have instruction to reproduce ? I don't have this version installed anymore right now

I use your last Commits in my fork.... I just do a photo in portrait or landscape and the orientation still wrong for me...

DoM1niC · 2022-10-05T19:47:25Z

THX for the fix ae2a920

we need some resolve :(

DoM1niC · 2022-10-08T13:28:38Z

@p1gp1g can you resolve all issues from your current code ? THX 4 your Work!!!!

bmarty added the Z-Community-PR Issue is solved by a community member's PR label Aug 16, 2022

bmarty requested a review from onurays August 16, 2022 15:07

p1gp1g added 14 commits August 27, 2022 11:48

Add VideoCamera button for attachment

51b905f

Add internal Camera : take photo

59546b0

Add internal Camera : record video

8fcc9c2

Create tempfile in the fragment

59e0c1e

Use VectorCameraOutput

Change capture mode in camera view

6b4fef9

Change camera in camera view

764ef53

Restore capture mode in camera view

a215fe2

Add gesture to zoom in camera view

e916709

Remove intent action for camera activity

f56a8fe

Set the built-in camera as a lab preference

90e922b

Control flash in camera view

d534a7d

Lint

9945231

Add progress indicator when taking a photo

0e3a8a1

Add changelog detail

8236a32

Signed-off-by: sim <git@sgougeon.fr>

p1gp1g force-pushed the feature/camera1 branch from 78517e3 to 8236a32 Compare August 27, 2022 14:22

Add support for orientation

4856fc6

p1gp1g marked this pull request as draft August 29, 2022 09:08

p1gp1g added 4 commits August 29, 2022 21:15

Camera: Follow the MVI pattern

ec1e5e2

Camera: Add UI tests

3776305

Do not use "VectorCamera" for names

9bca9bd

Fix dependencies.gradle for androidx.camera

bbdfa6e

p1gp1g marked this pull request as ready for review August 29, 2022 20:49

p1gp1g added 3 commits September 5, 2022 18:53

Enable orientationEventListener onStart

08ae120

Lint

db5e582

Add chronometer to camera view

d88371d

p1gp1g added 3 commits September 5, 2022 21:42

Use new UX for the camera

ccf0c88

Start recording a video onLongClick

Import drawable and fix colors

916cc2e

Fix UI test for the video camera

772e97b

p1gp1g added 5 commits September 6, 2022 20:21

Better style/UX

8cad95d

Use simpleActivityWaitingView, stop camera preview Remove unused executer

Use OnImageCapturedCallback to improve latency

23fa3c9

Fix UI tests for the camera

d5039dc

Add Camera Action description

d43b144

Fix chronometer visibility

64f3b2e

p1gp1g added 4 commits September 12, 2022 23:22

Change text size and chrono margin

4eac12d

Use recording and done states

8114f5b

Revert "Add VideoCamera button for attachment"

a28fb0d

These changes are not directly related to an inApp Camera. This reverts commit 51b905f. This reverts some change in 9945231.

Use common icon to flip camera

a5d87e6

Fix image rotation

ae2a920

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add in-app camera #6763

Add in-app camera #6763

p1gp1g commented Aug 7, 2022 •

edited

Loading

bmarty commented Aug 16, 2022

DoM1niC commented Aug 24, 2022 •

edited

Loading

DoM1niC commented Aug 26, 2022 •

edited

Loading

p1gp1g commented Aug 26, 2022

p1gp1g commented Aug 27, 2022 •

edited

Loading

p1gp1g commented Aug 27, 2022

p1gp1g commented Aug 29, 2022

onurays commented Sep 5, 2022

p1gp1g commented Sep 5, 2022 •

edited

Loading

p1gp1g commented Sep 6, 2022 •

edited

Loading

kojid0 commented Sep 6, 2022

p1gp1g commented Sep 6, 2022

kojid0 commented Sep 6, 2022 •

edited

Loading

p1gp1g commented Sep 12, 2022

DoM1niC commented Sep 29, 2022 •

edited

Loading

p1gp1g commented Sep 29, 2022

DoM1niC commented Oct 1, 2022

DoM1niC commented Oct 5, 2022

DoM1niC commented Oct 8, 2022

Add in-app camera #6763

Are you sure you want to change the base?

Add in-app camera #6763

Conversation

p1gp1g commented Aug 7, 2022 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tested devices

Checklist

bmarty commented Aug 16, 2022

DoM1niC commented Aug 24, 2022 • edited Loading

DoM1niC commented Aug 26, 2022 • edited Loading

p1gp1g commented Aug 26, 2022

p1gp1g commented Aug 27, 2022 • edited Loading

p1gp1g commented Aug 27, 2022

p1gp1g commented Aug 29, 2022

onurays commented Sep 5, 2022

p1gp1g commented Sep 5, 2022 • edited Loading

p1gp1g commented Sep 6, 2022 • edited Loading

kojid0 commented Sep 6, 2022

p1gp1g commented Sep 6, 2022

kojid0 commented Sep 6, 2022 • edited Loading

p1gp1g commented Sep 12, 2022

DoM1niC commented Sep 29, 2022 • edited Loading

p1gp1g commented Sep 29, 2022

DoM1niC commented Oct 1, 2022

DoM1niC commented Oct 5, 2022

DoM1niC commented Oct 8, 2022

p1gp1g commented Aug 7, 2022 •

edited

Loading

DoM1niC commented Aug 24, 2022 •

edited

Loading

DoM1niC commented Aug 26, 2022 •

edited

Loading

p1gp1g commented Aug 27, 2022 •

edited

Loading

p1gp1g commented Sep 5, 2022 •

edited

Loading

p1gp1g commented Sep 6, 2022 •

edited

Loading

kojid0 commented Sep 6, 2022 •

edited

Loading

DoM1niC commented Sep 29, 2022 •

edited

Loading