Remove element-builder specific scripts (#586)

element-hq · Mar 29, 2023 · 40058d3 · 40058d3
1 parent 762881b
commit 40058d3
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 124 deletions.
diff --git a/package.json b/package.json
@@ -157,14 +157,12 @@
     "win": {
       "target": [
         "squirrel"
-      ],
-      "sign": "scripts/electron_winSign"
+      ]
     },
     "directories": {
       "output": "dist"
     },
     "afterPack": "scripts/electron_afterPack",
-    "afterSign": "scripts/electron_afterSign",
     "protocols": [
       {
         "name": "element",

diff --git a/scripts/electron_afterSign.js b/scripts/electron_afterSign.js
diff --git a/scripts/electron_winSign.js b/scripts/electron_winSign.js
diff --git a/scripts/generate-builder-config.ts b/scripts/generate-builder-config.ts
@@ -8,7 +8,7 @@
  *  Prefixes the nightly version with `0.0.1-nightly.` as it breaks if it is not semver
  *
  * On macOS:
- *   Passes --notarytool-team-id to build.mac.notarize.notarize if specified and removes build.mac.afterSign
+ *   Passes --notarytool-team-id to build.mac.notarize.notarize if specified
  *
  * On Linux:
  *  Replaces spaces in the product name with dashes as spaces in paths can cause issues
@@ -87,14 +87,12 @@ async function main(): Promise<number | void> {
     }
 
     if (argv["signtool-thumbprint"] && argv["signtool-subject-name"]) {
-        delete cfg.win!.sign;
         cfg.win!.signingHashAlgorithms = ["sha256"];
         cfg.win!.certificateSubjectName = argv["signtool-subject-name"];
         cfg.win!.certificateSha1 = argv["signtool-thumbprint"];
     }
 
     if (argv["notarytool-team-id"]) {
-        delete cfg.afterSign;
         cfg.mac!.notarize = {
             teamId: argv["notarytool-team-id"],
         };