Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UI for outbound VoIP call screen #598

Closed
giomfo opened this issue Sep 9, 2016 · 9 comments
Closed

Better UI for outbound VoIP call screen #598

giomfo opened this issue Sep 9, 2016 · 9 comments
Labels
feature P2 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Sep 9, 2016

The call screen UI need some changes

  • the full size avatar in case of 1:1 call is ugly for most of the users. Indeed most of avatars are squared, so the avatar is cropped on the call screen...
  • some call control icons are missing (audio mute/unmute, speaker on/off...)
  • The case where no avatar is defined is not designed.
@ara4n ara4n changed the title Better UI for VoIP call screen Better UI for outbound VoIP call screen Sep 9, 2016
@giomfo
Copy link
Member Author

giomfo commented Sep 13, 2016

We agree with Ben's design for avatar display: https://zpl.io/Z1l1MlN.
We already implemented the rounded avatar, we have to add the pulse animation (and the avatar of the user himself at the bottom).

About call control, we would like to suggest the following points:

  • The hang-up icon must be pink red (instead of vector green).
  • The hang-up icon should be displayed in the middle of the bottom bar.
  • We need a "back to App" icon at the top left corner. When the user presses this icon, we switch back to the app by keeping running the call.
  • We would prefer remove the chevron beside the Room name. The user is able to select Chat icon from the bottom bar to go back into the room.
  • Audio mute: we suggest using the same image (a barred micro) with 2 states enable/disable.
  • Video mute: we suggest using the same image (a barred camera) with 2 states enable/disable.
  • Speaker: This icon is missing - we suggest using the same image with 2 states enable/disable.

@giomfo giomfo added this to the design_sprint1 milestone Sep 13, 2016
@benbreckler
Copy link

Hey Giom,

Thanks for outlining the details above. I added the pink hang-up icon to the bottom bar and used a back button to get back to the chat. In order to avoid duplication I removed the chat icon on the bottom bar. All states now have on off icons. You can find them on the screens below. I'm not sure Speaker icons are needed as this should be handled via the ringer phone switch?

On States https://zpl.io/2u1V4x
Off States https://zpl.io/Z14SPGW

@giomfo
Copy link
Member Author

giomfo commented Sep 14, 2016

Thanks Ben, here are my remarks:

  • pink hang up and back icons are ok.
  • the back button is used to get back to the current app screen which may not be the room chat. For example if the user accepts a call whereas the app settings screen is displayed, back button will return in the settings screen. In conclusion the chat icon in the bottom bar is still relevant. Could you please restore it?
  • Speaker icons are required, we would like to display this option in the bottom bar.
  • About icons with 2 states, we would like the same image for the both states. And use a different color for each state. For audio and video mute icons, we expect the images presented in https://zpl.io/Z14SPGW (barred micro and barred camera).

@giomfo giomfo removed their assignment Sep 14, 2016
@benbreckler
Copy link

Ok thanks for your feedback. I updated the screens here. You can extract the on / off assets from Zeplin.

https://zpl.io/2u1V4x
https://zpl.io/Z14SPGW

@giomfo
Copy link
Member Author

giomfo commented Sep 14, 2016

Ben, there is still one requirement about on/off assets.

About icons with 2 states, we would like the same image for the both states. And use a different color for each state. For audio and video mute icons, we expect the images presented in https://zpl.io/Z14SPGW (barred micro and barred camera).

To sum up:

  • barred micro in gray -> audio mute disabled (available in https://zpl.io/Z14SPGW)
  • barred micro in green -> audio mute enabled
  • barred camera in gray -> video mute disabled (available in https://zpl.io/Z14SPGW)
  • barred camera in green -> video mute enabled
  • speaker in gray -> speakerphone is disabled
  • speaker in green -> speakerphone is enabled (available in https://zpl.io/2u1V4x)

CAUTION: speaker icon in green is no exportable in https://zpl.io/2u1V4x.

@giomfo giomfo removed their assignment Sep 14, 2016
@benbreckler
Copy link

I updated the On state icons to have the same bar running through the icons. https://zpl.io/2u1V4x

@benbreckler benbreckler assigned giomfo and unassigned benbreckler Sep 15, 2016
@giomfo
Copy link
Member Author

giomfo commented Sep 15, 2016

Note: @benbreckler provided a voice call design here: https://zpl.io/ZrzEJ0
https://zpl.io/Z1l1MlN

@giomfo giomfo removed the design label Sep 15, 2016
@giomfo giomfo removed this from the design_sprint1 milestone Sep 15, 2016
@giomfo
Copy link
Member Author

giomfo commented Sep 15, 2016

final design (https://zpl.io/2u1V4x, https://zpl.io/Z14SPGW) is signed off

giomfo added a commit that referenced this issue Sep 19, 2016
@giomfo giomfo added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements feature P2 and removed P1 labels Mar 30, 2017
@giomfo giomfo removed their assignment Mar 30, 2017
@ismailgulek
Copy link
Contributor

Please see the new UI in 1.2.1

langleyd pushed a commit that referenced this issue Mar 29, 2023
* Fix leading whitespace getting ignored by parsers

* Add test for multiple leading/trailing whitespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature P2 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

3 participants