Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media picker: Switching camera button and exit button are not very visible #610

Closed
giomfo opened this issue Sep 13, 2016 · 8 comments
Closed
Assignees
Labels

Comments

@giomfo
Copy link
Member

giomfo commented Sep 13, 2016

A shame because it's beautiful but makes it harder to use. Nead an alternative design

@benbreckler
Copy link

I added the header bar background to the camera view too. See #533

@giomfo
Copy link
Member Author

giomfo commented Sep 15, 2016

Matthew, what do you think about the white header suggested by Ben? https://zpl.io/ZB7zyY

I'm not really convinced by this solution. Why not use a rounded background (white) for these 2 buttons?

@ara4n
Copy link
Member

ara4n commented Sep 15, 2016

yeah, it's a real shame to lose all that space to a toolbar. i think a rounded white background would also look ugly though - but it might work if it was translucent (a bit like how the volume control overlay works on iOS9+?)

@benbreckler
Copy link

Ok here is the iterated version of the controls https://zpl.io/ZB7zyY

@benbreckler benbreckler assigned giomfo and unassigned benbreckler Sep 15, 2016
@ara4n
Copy link
Member

ara4n commented Sep 15, 2016

this is a definite improvement - any hope of going for translucent white on the bg?

@giomfo giomfo assigned benbreckler and unassigned ara4n and giomfo Sep 15, 2016
@benbreckler
Copy link

Ok I updated the background to have 40% opacity and 10px background blur. https://zpl.io/ZB7zyY

@benbreckler benbreckler assigned ara4n and giomfo and unassigned benbreckler Sep 16, 2016
@giomfo
Copy link
Member Author

giomfo commented Sep 16, 2016

signed off

@giomfo giomfo removed the design label Sep 16, 2016
@giomfo giomfo removed this from the design_sprint1 milestone Sep 16, 2016
@giomfo
Copy link
Member Author

giomfo commented Sep 20, 2016

For information, I decided to use a black background with 40% opacity. This improves the rendering contrast, see the following screenshots:
screen shot 2016-09-20 at 10 35 18
screen shot 2016-09-20 at 10 35 32
screen shot 2016-09-20 at 10 35 41

giomfo added a commit that referenced this issue Sep 20, 2016
…t very visible

#610

We added a black translucent background.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants