Improvements in notification registration flow #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem:
Imagine that you disabled notifications for Riot on a system level, then when you'll try enable them on the settings screen and you'll see an alert which advices you to go to the system settings and enable them there. After you did that you return to the Riot and will try to enable them again but you will see the same alert.
Also if user has disabled notification between launches we don't delete stored push token, so server will send pushes, but we can't process them, since we don't have access to notifications.
It will be better to merge this with PushKit in the future.
Signed-off-by: Denis Morozov dmorozkn@gmail.com