Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "password" as "Matrix account password" #5458

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

elsiehupp
Copy link
Contributor

Signed-off-by: Elsie Hupp github@elsiehupp.com

Fixes #5457.

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@elsiehupp
Copy link
Contributor Author

Please let me know if any of the strings I changed from "password" to "Matrix account password" do not, in fact, refer to the Matrix account password.

I did this entirely via the GitHub web interface—hence the ugly patch-1 branch name—so it is somewhat less than straightforward for me to test or add a changelog entry. I probably can do all that manually if necessary, but this was just a spur-of-the-moment thing.

@daniellekirkwood
Copy link
Contributor

In some cases the copy is now quite long, but it's better to be clear than concise so let's implement these changes and review if needed.

Thank you!

@stefanceriu
Copy link
Member

Yes, thank you for taking the time 👍

@stefanceriu stefanceriu merged commit 4bccbac into element-hq:develop Feb 8, 2022
@elsiehupp
Copy link
Contributor Author

You’re welcome! (I do have some other UX feedback that I’ll try and write up soon.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Please enter your password" is ambiguous
3 participants