Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check power level before starting live sharing location #7832

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

pixlwave
Copy link
Member

#7808 cherry picked and squashed without the commits from #7778.

Original sign off is in the previous PR.

Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com>

Update RiotSwiftUI/Modules/LocationSharing/StartLocationSharing/Coordinator/LocationSharingCoordinator.swift

Use local var `roomPowerLevels`

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Copy link

sonarcloud bot commented Aug 14, 2024

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (aa86f39) to head (979fb20).
Report is 49 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7832       +/-   ##
============================================
+ Coverage    12.35%   55.67%   +43.31%     
============================================
  Files         1653      449     -1204     
  Lines       164182    18917   -145265     
  Branches     67276     7965    -59311     
============================================
- Hits         20286    10532     -9754     
+ Misses      143257     8156   -135101     
+ Partials       639      229      -410     
Flag Coverage Δ
uitests 55.67% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit c4387b9 into develop Aug 14, 2024
8 checks passed
@pixlwave pixlwave deleted the doug/live-location-power-level branch August 14, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant