Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening and closing widgets can cause them to show a blank screen #11536

Closed
turt2live opened this issue Nov 27, 2019 · 7 comments · Fixed by matrix-org/matrix-react-sdk#3681
Closed

Opening and closing widgets can cause them to show a blank screen #11536

turt2live opened this issue Nov 27, 2019 · 7 comments · Fixed by matrix-org/matrix-react-sdk#3681
Assignees
@turt2live
Labels
A-Widgets P1 T-Defect X-Regression

Comments

@turt2live
Copy link
Member

This is a recurring regression. See #6707 for the last time.

Likely to be highly related to #10499
@rxl881
Copy link
Contributor

rxl881 commented Nov 27, 2019

Seeing the same with Modular widgets, for example Etherpad too

@rxl881
Copy link
Contributor

rxl881 commented Nov 27, 2019

I actually think that this might be related to a failure to get the widget capabilities. Seeing the following for an Etherpad widget, for example:
Screenshot 2019-11-27 at 16 09 55

@turt2live
Copy link
Member Author

It's because our persistent app stuff is failing to re-mount the correct widget I believe. A side effect of that is the capabilities exploding.

@rxl881
Copy link
Contributor

rxl881 commented Nov 27, 2019

I'm also seeing invalid scalar token errors (which I would not expect), as I haven't changed anything, and nothing has changed in scalar (to my knowledge).

Could the persistant app stuff also be affecting cookie loading (or could that be linked to something else, e.g. CSP changes)?

@turt2live turt2live self-assigned this Nov 27, 2019
@turt2live
Copy link
Member Author

Could the persistant app stuff also be affecting cookie loading (or could that be linked to something else, e.g. CSP changes)?

Yes, it affects the whole bootstrap process.

@turt2live
Copy link
Member Author

@rxl881 your etherpad problem might be something slightly more subtle, actually. If you've changed integration managers or your Scalar token is no longer valid then there's a good chance it won't work. If that's the case, that would be a different (new) issue.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 27, 2019
@turt2live
Fix persisted widgets getting stuck at loading screens
7b013ec 
The widget itself is rendered underneath the loading screen, so we just have to disable the loading state.

This commit also removes the "is" attribute because React 16 includes unknown attributes: https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html

Fixes element-hq/element-web#11536
@turt2live turt2live mentioned this issue Nov 27, 2019
Merged
@rxl881
Copy link
Contributor

rxl881 commented Nov 27, 2019

@turt2live -- Yeah, but I really haven't changed integration managers or done anything else that would have (should have) invalidated the scalar token recently. Definitely still possible to be something unrelated in scalar though.

@makyo -- can you please check that (existing) scalar Etherpad and Grafana widgets are working for you, just to confirm the general breakage case, and to determine if there is any evidence that there is something additional, Scalar-specific going on (and if so log it as a new issue)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Widgets P1 T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix persisted widgets getting stuck at loading screens matrix-org/matrix-react-sdk
2 participants
@turt2live @rxl881