Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thumbnail filesize can be bigger than the original image #17906

Closed
uhoreg opened this issue Jul 7, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6559
Closed

thumbnail filesize can be bigger than the original image #17906

uhoreg opened this issue Jul 7, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6559

Comments

@uhoreg
Copy link
Member

uhoreg commented Jul 7, 2021

For example, https://matrix.to/#/!bEWtlqtDwCLFIAKAcv:matrix.org/$RZTZTqR8xROKD6i_cnuPgW-NVmHHiTRIwie2b3poUaI?via=matrix.org&via=vector.modular.im&via=dataport.modular.im has a file size of 17226 for the image, but the file size of the thumbnail is 22985, which seems silly and defeats the purpose of having a thumbnail. We should detect if the generated thumbnail is bigger than the original image, and if so, we shouldn't upload the thumbnail, and should simply use the original image as the thumbnail instead

@lub
Copy link
Contributor

lub commented Jul 17, 2021

Considering that the thumbnail quality is often also worse than the original image even with similar size, it would imo also make sense to only upload a 'proper' thumbnail after a certain threshold.

For example only upload the thumbnail if it is 10% or 1MB smaller than the original.

Under a certain size it maybe even makes sense to just not generate a thumbnail at all. I mean why have a thumbnail for a 17kb image? I don't know the resolution of the linked example, but a minimum resolution could maybe also be an additional consideration.

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2021

image

yeah this is happening all over the place

@t3chguy t3chguy self-assigned this Aug 5, 2021
@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2021

Anecdotally I've found that FF generates better thumbnails, for the OP where Chrome did 17226->22985 FF managed 17226->17564 ; but still, larger

BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Aug 13, 2021
* Show how long a call was on call tiles ([\element-hq#6570](matrix-org/matrix-react-sdk#6570)). Fixes element-hq#18405. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add regional indicators to emoji picker ([\element-hq#6490](matrix-org/matrix-react-sdk#6490)). Fixes element-hq#14963. Contributed by [robintown](https://github.com/robintown).
* Make call control buttons accessible to screen reader users ([\element-hq#6181](matrix-org/matrix-react-sdk#6181)). Fixes element-hq#18358. Contributed by [pvagner](https://github.com/pvagner).
* Skip sending a thumbnail if it is not a sufficient saving over the original ([\element-hq#6559](matrix-org/matrix-react-sdk#6559)). Fixes element-hq#17906.
* Increase PiP snapping speed ([\element-hq#6539](matrix-org/matrix-react-sdk#6539)). Fixes element-hq#18371. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve and move the incoming call toast ([\element-hq#6470](matrix-org/matrix-react-sdk#6470)). Fixes element-hq#17912. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow all of the URL schemes that Firefox allows ([\element-hq#6457](matrix-org/matrix-react-sdk#6457)). Contributed by [aaronraimist](https://github.com/aaronraimist).
* Improve bubble layout colors ([\element-hq#6452](matrix-org/matrix-react-sdk#6452)). Fixes element-hq#18081. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Spaces let users switch between Home and All Rooms behaviours ([\element-hq#6497](matrix-org/matrix-react-sdk#6497)). Fixes element-hq#18093.
* Support for MSC2285 (hidden read receipts) ([\element-hq#6390](matrix-org/matrix-react-sdk#6390)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Group pinned message events with MELS ([\element-hq#6349](matrix-org/matrix-react-sdk#6349)). Fixes element-hq#17938. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make version copiable ([\element-hq#6227](matrix-org/matrix-react-sdk#6227)). Fixes element-hq#17603 and element-hq#18329. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve voice messages uploading state ([\element-hq#6530](matrix-org/matrix-react-sdk#6530)). Fixes element-hq#18226 and element-hq#18224.
* Add surround with feature ([\element-hq#5510](matrix-org/matrix-react-sdk#5510)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve call event tile wording ([\element-hq#6545](matrix-org/matrix-react-sdk#6545)). Fixes element-hq#18376. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show an avatar/a turned off microphone icon for muted users ([\element-hq#6486](matrix-org/matrix-react-sdk#6486)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Prompt user to leave rooms/subspaces in a space when leaving space ([\element-hq#6424](matrix-org/matrix-react-sdk#6424)). Fixes element-hq#18071.
* none ([\element-hq#6455](matrix-org/matrix-react-sdk#6455)). Fixes element-hq#18035.
* Add support for screen sharing in 1:1 calls ([\element-hq#5992](matrix-org/matrix-react-sdk#5992)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Dismiss electron download toast when clicking Open ([\element-hq#18267](element-hq#18267)). Fixes element-hq#18266.
* Fix [object Object] in Widget Permissions ([\element-hq#6560](matrix-org/matrix-react-sdk#6560)). Fixes element-hq#18384. Contributed by [Palid](https://github.com/Palid).
* Fix right margin for events on IRC layout ([\element-hq#6542](matrix-org/matrix-react-sdk#6542)). Fixes element-hq#18354.
* Mirror only usermedia feeds ([\element-hq#6512](matrix-org/matrix-react-sdk#6512)). Fixes element-hq#5633. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix LogoutDialog warning + TypeScript migration ([\element-hq#6533](matrix-org/matrix-react-sdk#6533)).
* Fix the wrong font being used in the room topic field ([\element-hq#6527](matrix-org/matrix-react-sdk#6527)). Fixes element-hq#18339. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix inconsistent styling for links on hover ([\element-hq#6513](matrix-org/matrix-react-sdk#6513)). Contributed by [janogarcia](https://github.com/janogarcia).
* Fix incorrect height for encoded placeholder images ([\element-hq#6514](matrix-org/matrix-react-sdk#6514)). Contributed by [Palid](https://github.com/Palid).
* Fix call events layout for message bubble ([\element-hq#6465](matrix-org/matrix-react-sdk#6465)). Fixes element-hq#18144.
* Improve subspaces and some utilities around room/space creation ([\element-hq#6458](matrix-org/matrix-react-sdk#6458)). Fixes element-hq#18090 element-hq#18091 and element-hq#17256.
* Restore pointer cursor for SenderProfile in message bubbles ([\element-hq#6501](matrix-org/matrix-react-sdk#6501)). Fixes element-hq#18249.
* Fix issues with the Call View ([\element-hq#6472](matrix-org/matrix-react-sdk#6472)). Fixes element-hq#18221. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Align event list summary read receipts when using message bubbles ([\element-hq#6500](matrix-org/matrix-react-sdk#6500)). Fixes element-hq#18143.
* Better positioning for unbubbled events in timeline ([\element-hq#6477](matrix-org/matrix-react-sdk#6477)). Fixes element-hq#18132.
* Realign reactions row with messages in modern layout ([\element-hq#6491](matrix-org/matrix-react-sdk#6491)). Fixes element-hq#18118. Contributed by [robintown](https://github.com/robintown).
* Fix CreateRoomDialog exploding when making public room outside of a space ([\element-hq#6492](matrix-org/matrix-react-sdk#6492)). Fixes element-hq#18275.
* Fix call crashing because `element` was undefined ([\element-hq#6488](matrix-org/matrix-react-sdk#6488)). Fixes element-hq#18270. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Upscale thumbnails to the container size ([\element-hq#6589](matrix-org/matrix-react-sdk#6589)). Fixes element-hq#18307.
* Fix create room dialog in spaces no longer adding to the space ([\element-hq#6587](matrix-org/matrix-react-sdk#6587)). Fixes element-hq#18465.
* Don't show a modal on call reject/user hangup ([\element-hq#6580](matrix-org/matrix-react-sdk#6580)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fade Call View Buttons after `componentDidMount` ([\element-hq#6581](matrix-org/matrix-react-sdk#6581)). Fixes element-hq#18439. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix missing expand button on codeblocks ([\element-hq#6565](matrix-org/matrix-react-sdk#6565)). Fixes element-hq#18388. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* allow customizing the bubble layout colors ([\element-hq#6568](matrix-org/matrix-react-sdk#6568)). Fixes element-hq#18408. Contributed by [benneti](https://github.com/benneti).
* Don't flash "Missed call" when accepting a call ([\element-hq#6567](matrix-org/matrix-react-sdk#6567)). Fixes element-hq#18404. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix clicking whitespaces on replies ([\element-hq#6571](matrix-org/matrix-react-sdk#6571)). Fixes element-hq#18327. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix composer not being disabled when sending voice messages ([\element-hq#6562](matrix-org/matrix-react-sdk#6562)). Fixes element-hq#18413.
* none ([\element-hq#6550](matrix-org/matrix-react-sdk#6550)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix sizing issues of the screen picker ([\element-hq#6498](matrix-org/matrix-react-sdk#6498)). Fixes element-hq#18281. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Stop voice messages that are playing when starting a recording ([\element-hq#6563](matrix-org/matrix-react-sdk#6563)). Fixes element-hq#18410.
* Fix random box appearing when clicking room list headers. ([\element-hq#6561](matrix-org/matrix-react-sdk#6561)). Fixes element-hq#18414.
* Null guard space inviter to prevent the app exploding ([\element-hq#6558](matrix-org/matrix-react-sdk#6558)).
* Make the ringing sound mutable/disablable ([\element-hq#6534](matrix-org/matrix-react-sdk#6534)). Fixes element-hq#15591. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix wrong cursor being used in PiP ([\element-hq#6551](matrix-org/matrix-react-sdk#6551)). Fixes element-hq#18383. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Re-pin Jitsi if the widget already exists ([\element-hq#6226](matrix-org/matrix-react-sdk#6226)). Fixes element-hq#17679. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix broken call notification regression ([\element-hq#6526](matrix-org/matrix-react-sdk#6526)). Fixes element-hq#18335. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* createRoom, only send join rule event if we have a join rule to put in it ([\element-hq#6516](matrix-org/matrix-react-sdk#6516)). Fixes element-hq#18301.
* Fix clicking pills inside replies ([\element-hq#6508](matrix-org/matrix-react-sdk#6508)). Fixes element-hq#18283. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix grecaptcha regression ([\element-hq#6503](matrix-org/matrix-react-sdk#6503)). Fixes element-hq#18284. Contributed by [Palid](https://github.com/Palid).
* Fix compatibility with accounts where the security passphrase was created on a mobile device ([\element-hq#1819](matrix-org/matrix-js-sdk#1819)).
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Aug 16, 2021
* Show how long a call was on call tiles ([\element-hq#6570](matrix-org/matrix-react-sdk#6570)). Fixes element-hq#18405. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add regional indicators to emoji picker ([\element-hq#6490](matrix-org/matrix-react-sdk#6490)). Fixes element-hq#14963. Contributed by [robintown](https://github.com/robintown).
* Make call control buttons accessible to screen reader users ([\element-hq#6181](matrix-org/matrix-react-sdk#6181)). Fixes element-hq#18358. Contributed by [pvagner](https://github.com/pvagner).
* Skip sending a thumbnail if it is not a sufficient saving over the original ([\element-hq#6559](matrix-org/matrix-react-sdk#6559)). Fixes element-hq#17906.
* Increase PiP snapping speed ([\element-hq#6539](matrix-org/matrix-react-sdk#6539)). Fixes element-hq#18371. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve and move the incoming call toast ([\element-hq#6470](matrix-org/matrix-react-sdk#6470)). Fixes element-hq#17912. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow all of the URL schemes that Firefox allows ([\element-hq#6457](matrix-org/matrix-react-sdk#6457)). Contributed by [aaronraimist](https://github.com/aaronraimist).
* Improve bubble layout colors ([\element-hq#6452](matrix-org/matrix-react-sdk#6452)). Fixes element-hq#18081. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Spaces let users switch between Home and All Rooms behaviours ([\element-hq#6497](matrix-org/matrix-react-sdk#6497)). Fixes element-hq#18093.
* Support for MSC2285 (hidden read receipts) ([\element-hq#6390](matrix-org/matrix-react-sdk#6390)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Group pinned message events with MELS ([\element-hq#6349](matrix-org/matrix-react-sdk#6349)). Fixes element-hq#17938. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make version copiable ([\element-hq#6227](matrix-org/matrix-react-sdk#6227)). Fixes element-hq#17603 and element-hq#18329. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve voice messages uploading state ([\element-hq#6530](matrix-org/matrix-react-sdk#6530)). Fixes element-hq#18226 and element-hq#18224.
* Add surround with feature ([\element-hq#5510](matrix-org/matrix-react-sdk#5510)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve call event tile wording ([\element-hq#6545](matrix-org/matrix-react-sdk#6545)). Fixes element-hq#18376. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show an avatar/a turned off microphone icon for muted users ([\element-hq#6486](matrix-org/matrix-react-sdk#6486)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Prompt user to leave rooms/subspaces in a space when leaving space ([\element-hq#6424](matrix-org/matrix-react-sdk#6424)). Fixes element-hq#18071.
* Add support for screen sharing in 1:1 calls ([\element-hq#5992](matrix-org/matrix-react-sdk#5992)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Dismiss electron download toast when clicking Open ([\element-hq#18267](element-hq#18267)). Fixes element-hq#18266.
* [Release] Fix glare related regressions ([\element-hq#6622](matrix-org/matrix-react-sdk#6622)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix PiP of held calls ([\element-hq#6612](matrix-org/matrix-react-sdk#6612)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix toast colors ([\element-hq#6607](matrix-org/matrix-react-sdk#6607)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix [object Object] in Widget Permissions ([\element-hq#6560](matrix-org/matrix-react-sdk#6560)). Fixes element-hq#18384. Contributed by [Palid](https://github.com/Palid).
* Fix right margin for events on IRC layout ([\element-hq#6542](matrix-org/matrix-react-sdk#6542)). Fixes element-hq#18354.
* Mirror only usermedia feeds ([\element-hq#6512](matrix-org/matrix-react-sdk#6512)). Fixes element-hq#5633. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix LogoutDialog warning + TypeScript migration ([\element-hq#6533](matrix-org/matrix-react-sdk#6533)).
* Fix the wrong font being used in the room topic field ([\element-hq#6527](matrix-org/matrix-react-sdk#6527)). Fixes element-hq#18339. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix inconsistent styling for links on hover ([\element-hq#6513](matrix-org/matrix-react-sdk#6513)). Contributed by [janogarcia](https://github.com/janogarcia).
* Fix incorrect height for encoded placeholder images ([\element-hq#6514](matrix-org/matrix-react-sdk#6514)). Contributed by [Palid](https://github.com/Palid).
* Fix call events layout for message bubble ([\element-hq#6465](matrix-org/matrix-react-sdk#6465)). Fixes element-hq#18144.
* Improve subspaces and some utilities around room/space creation ([\element-hq#6458](matrix-org/matrix-react-sdk#6458)). Fixes element-hq#18090 element-hq#18091 and element-hq#17256.
* Restore pointer cursor for SenderProfile in message bubbles ([\element-hq#6501](matrix-org/matrix-react-sdk#6501)). Fixes element-hq#18249.
* Fix issues with the Call View ([\element-hq#6472](matrix-org/matrix-react-sdk#6472)). Fixes element-hq#18221. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Align event list summary read receipts when using message bubbles ([\element-hq#6500](matrix-org/matrix-react-sdk#6500)). Fixes element-hq#18143.
* Better positioning for unbubbled events in timeline ([\element-hq#6477](matrix-org/matrix-react-sdk#6477)). Fixes element-hq#18132.
* Realign reactions row with messages in modern layout ([\element-hq#6491](matrix-org/matrix-react-sdk#6491)). Fixes element-hq#18118. Contributed by [robintown](https://github.com/robintown).
* Fix CreateRoomDialog exploding when making public room outside of a space ([\element-hq#6492](matrix-org/matrix-react-sdk#6492)). Fixes element-hq#18275.
* Fix call crashing because `element` was undefined ([\element-hq#6488](matrix-org/matrix-react-sdk#6488)). Fixes element-hq#18270. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Upscale thumbnails to the container size ([\element-hq#6589](matrix-org/matrix-react-sdk#6589)). Fixes element-hq#18307.
* Fix create room dialog in spaces no longer adding to the space ([\element-hq#6587](matrix-org/matrix-react-sdk#6587)). Fixes element-hq#18465.
* Don't show a modal on call reject/user hangup ([\element-hq#6580](matrix-org/matrix-react-sdk#6580)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fade Call View Buttons after `componentDidMount` ([\element-hq#6581](matrix-org/matrix-react-sdk#6581)). Fixes element-hq#18439. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix missing expand button on codeblocks ([\element-hq#6565](matrix-org/matrix-react-sdk#6565)). Fixes element-hq#18388. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* allow customizing the bubble layout colors ([\element-hq#6568](matrix-org/matrix-react-sdk#6568)). Fixes element-hq#18408. Contributed by [benneti](https://github.com/benneti).
* Don't flash "Missed call" when accepting a call ([\element-hq#6567](matrix-org/matrix-react-sdk#6567)). Fixes element-hq#18404. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix clicking whitespaces on replies ([\element-hq#6571](matrix-org/matrix-react-sdk#6571)). Fixes element-hq#18327. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix composer not being disabled when sending voice messages ([\element-hq#6562](matrix-org/matrix-react-sdk#6562)). Fixes element-hq#18413.
* Fix sizing issues of the screen picker ([\element-hq#6498](matrix-org/matrix-react-sdk#6498)). Fixes element-hq#18281. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Stop voice messages that are playing when starting a recording ([\element-hq#6563](matrix-org/matrix-react-sdk#6563)). Fixes element-hq#18410.
* Fix random box appearing when clicking room list headers. ([\element-hq#6561](matrix-org/matrix-react-sdk#6561)). Fixes element-hq#18414.
* Null guard space inviter to prevent the app exploding ([\element-hq#6558](matrix-org/matrix-react-sdk#6558)).
* Make the ringing sound mutable/disablable ([\element-hq#6534](matrix-org/matrix-react-sdk#6534)). Fixes element-hq#15591. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix wrong cursor being used in PiP ([\element-hq#6551](matrix-org/matrix-react-sdk#6551)). Fixes element-hq#18383. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Re-pin Jitsi if the widget already exists ([\element-hq#6226](matrix-org/matrix-react-sdk#6226)). Fixes element-hq#17679. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix broken call notification regression ([\element-hq#6526](matrix-org/matrix-react-sdk#6526)). Fixes element-hq#18335. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* createRoom, only send join rule event if we have a join rule to put in it ([\element-hq#6516](matrix-org/matrix-react-sdk#6516)). Fixes element-hq#18301.
* Fix clicking pills inside replies ([\element-hq#6508](matrix-org/matrix-react-sdk#6508)). Fixes element-hq#18283. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix grecaptcha regression ([\element-hq#6503](matrix-org/matrix-react-sdk#6503)). Fixes element-hq#18284. Contributed by [Palid](https://github.com/Palid).
* Fix compatibility with accounts where the security passphrase was created on a mobile device ([\element-hq#1819](matrix-org/matrix-js-sdk#1819)).
chayleaf added a commit to chayleaf/matrix-react-sdk that referenced this issue Aug 17, 2021
* Show how long a call was on call tiles ([\matrix-org#6570](matrix-org#6570)). Fixes element-hq/element-web#18405. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add regional indicators to emoji picker ([\matrix-org#6490](matrix-org#6490)). Fixes element-hq/element-web#14963. Contributed by [robintown](https://github.com/robintown).
* Make call control buttons accessible to screen reader users ([\matrix-org#6181](matrix-org#6181)). Fixes element-hq/element-web#18358. Contributed by [pvagner](https://github.com/pvagner).
* Skip sending a thumbnail if it is not a sufficient saving over the original ([\matrix-org#6559](matrix-org#6559)). Fixes element-hq/element-web#17906.
* Increase PiP snapping speed ([\matrix-org#6539](matrix-org#6539)). Fixes element-hq/element-web#18371. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve and move the incoming call toast ([\matrix-org#6470](matrix-org#6470)). Fixes element-hq/element-web#17912. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow all of the URL schemes that Firefox allows ([\matrix-org#6457](matrix-org#6457)). Contributed by [aaronraimist](https://github.com/aaronraimist).
* Improve bubble layout colors ([\matrix-org#6452](matrix-org#6452)). Fixes element-hq/element-web#18081. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Spaces let users switch between Home and All Rooms behaviours ([\matrix-org#6497](matrix-org#6497)). Fixes element-hq/element-web#18093.
* Support for MSC2285 (hidden read receipts) ([\matrix-org#6390](matrix-org#6390)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Group pinned message events with MELS ([\matrix-org#6349](matrix-org#6349)). Fixes element-hq/element-web#17938. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make version copiable ([\matrix-org#6227](matrix-org#6227)). Fixes element-hq/element-web#17603 and element-hq/element-web#18329. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve voice messages uploading state ([\matrix-org#6530](matrix-org#6530)). Fixes element-hq/element-web#18226 and element-hq/element-web#18224.
* Add surround with feature ([\matrix-org#5510](matrix-org#5510)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve call event tile wording ([\matrix-org#6545](matrix-org#6545)). Fixes element-hq/element-web#18376. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show an avatar/a turned off microphone icon for muted users ([\matrix-org#6486](matrix-org#6486)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Prompt user to leave rooms/subspaces in a space when leaving space ([\matrix-org#6424](matrix-org#6424)). Fixes element-hq/element-web#18071.
* Add customisation point to override widget variables ([\matrix-org#6455](matrix-org#6455)). Fixes element-hq/element-web#18035.
* Add support for screen sharing in 1:1 calls ([\matrix-org#5992](matrix-org#5992)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix glare related regressions ([\matrix-org#6622](matrix-org#6622)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix PiP of held calls ([\matrix-org#6612](matrix-org#6612)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix toast colors ([\matrix-org#6607](matrix-org#6607)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix [object Object] in Widget Permissions ([\matrix-org#6560](matrix-org#6560)). Fixes element-hq/element-web#18384. Contributed by [Palid](https://github.com/Palid).
* Fix right margin for events on IRC layout ([\matrix-org#6542](matrix-org#6542)). Fixes element-hq/element-web#18354.
* Mirror only usermedia feeds ([\matrix-org#6512](matrix-org#6512)). Fixes element-hq/element-web#5633. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix LogoutDialog warning + TypeScript migration ([\matrix-org#6533](matrix-org#6533)).
* Fix the wrong font being used in the room topic field ([\matrix-org#6527](matrix-org#6527)). Fixes element-hq/element-web#18339. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix inconsistent styling for links on hover ([\matrix-org#6513](matrix-org#6513)). Contributed by [janogarcia](https://github.com/janogarcia).
* Fix incorrect height for encoded placeholder images ([\matrix-org#6514](matrix-org#6514)). Contributed by [Palid](https://github.com/Palid).
* Fix call events layout for message bubble ([\matrix-org#6465](matrix-org#6465)). Fixes element-hq/element-web#18144.
* Improve subspaces and some utilities around room/space creation ([\matrix-org#6458](matrix-org#6458)). Fixes element-hq/element-web#18090 element-hq/element-web#18091 and element-hq/element-web#17256.
* Restore pointer cursor for SenderProfile in message bubbles ([\matrix-org#6501](matrix-org#6501)). Fixes element-hq/element-web#18249.
* Fix issues with the Call View ([\matrix-org#6472](matrix-org#6472)). Fixes element-hq/element-web#18221. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Align event list summary read receipts when using message bubbles ([\matrix-org#6500](matrix-org#6500)). Fixes element-hq/element-web#18143.
* Better positioning for unbubbled events in timeline ([\matrix-org#6477](matrix-org#6477)). Fixes element-hq/element-web#18132.
* Realign reactions row with messages in modern layout ([\matrix-org#6491](matrix-org#6491)). Fixes element-hq/element-web#18118. Contributed by [robintown](https://github.com/robintown).
* Fix CreateRoomDialog exploding when making public room outside of a space ([\matrix-org#6492](matrix-org#6492)). Fixes element-hq/element-web#18275.
* Fix call crashing because `element` was undefined ([\matrix-org#6488](matrix-org#6488)). Fixes element-hq/element-web#18270. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Upscale thumbnails to the container size ([\matrix-org#6589](matrix-org#6589)). Fixes element-hq/element-web#18307.
* Fix create room dialog in spaces no longer adding to the space ([\matrix-org#6587](matrix-org#6587)). Fixes element-hq/element-web#18465.
* Don't show a modal on call reject/user hangup ([\matrix-org#6580](matrix-org#6580)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fade Call View Buttons after `componentDidMount` ([\matrix-org#6581](matrix-org#6581)). Fixes element-hq/element-web#18439. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix missing expand button on codeblocks ([\matrix-org#6565](matrix-org#6565)). Fixes element-hq/element-web#18388. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* allow customizing the bubble layout colors ([\matrix-org#6568](matrix-org#6568)). Fixes element-hq/element-web#18408. Contributed by [benneti](https://github.com/benneti).
* Don't flash "Missed call" when accepting a call ([\matrix-org#6567](matrix-org#6567)). Fixes element-hq/element-web#18404. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix clicking whitespaces on replies ([\matrix-org#6571](matrix-org#6571)). Fixes element-hq/element-web#18327. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix disabled state for voice messages + send button tooltip ([\matrix-org#6562](matrix-org#6562)). Fixes element-hq/element-web#18413.
* Fix voice feed being cut-off ([\matrix-org#6550](matrix-org#6550)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix sizing issues of the screen picker ([\matrix-org#6498](matrix-org#6498)). Fixes element-hq/element-web#18281. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Stop voice messages that are playing when starting a recording ([\matrix-org#6563](matrix-org#6563)). Fixes element-hq/element-web#18410.
* Properly set style attribute on shared usercontent iframe ([\matrix-org#6561](matrix-org#6561)). Fixes element-hq/element-web#18414.
* Null guard space inviter to prevent the app exploding ([\matrix-org#6558](matrix-org#6558)).
* Make the ringing sound mutable/disablable ([\matrix-org#6534](matrix-org#6534)). Fixes element-hq/element-web#15591. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix wrong cursor being used in PiP ([\matrix-org#6551](matrix-org#6551)). Fixes element-hq/element-web#18383. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Re-pin Jitsi if the widget already exists ([\matrix-org#6226](matrix-org#6226)). Fixes element-hq/element-web#17679. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix broken call notification regression ([\matrix-org#6526](matrix-org#6526)). Fixes element-hq/element-web#18335. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* createRoom, only send join rule event if we have a join rule to put in it ([\matrix-org#6516](matrix-org#6516)). Fixes element-hq/element-web#18301.
* Fix clicking pills inside replies ([\matrix-org#6508](matrix-org#6508)). Fixes element-hq/element-web#18283. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix grecaptcha regression ([\matrix-org#6503](matrix-org#6503)). Fixes element-hq/element-web#18284. Contributed by [Palid](https://github.com/Palid).
williamkray added a commit to williamkray/element-web that referenced this issue Aug 17, 2021
* Show how long a call was on call tiles ([\element-hq#6570](matrix-org/matrix-react-sdk#6570)). Fixes element-hq#18405. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add regional indicators to emoji picker ([\element-hq#6490](matrix-org/matrix-react-sdk#6490)). Fixes element-hq#14963. Contributed by [robintown](https://github.com/robintown).
* Make call control buttons accessible to screen reader users ([\element-hq#6181](matrix-org/matrix-react-sdk#6181)). Fixes element-hq#18358. Contributed by [pvagner](https://github.com/pvagner).
* Skip sending a thumbnail if it is not a sufficient saving over the original ([\element-hq#6559](matrix-org/matrix-react-sdk#6559)). Fixes element-hq#17906.
* Increase PiP snapping speed ([\element-hq#6539](matrix-org/matrix-react-sdk#6539)). Fixes element-hq#18371. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve and move the incoming call toast ([\element-hq#6470](matrix-org/matrix-react-sdk#6470)). Fixes element-hq#17912. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow all of the URL schemes that Firefox allows ([\element-hq#6457](matrix-org/matrix-react-sdk#6457)). Contributed by [aaronraimist](https://github.com/aaronraimist).
* Improve bubble layout colors ([\element-hq#6452](matrix-org/matrix-react-sdk#6452)). Fixes element-hq#18081. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Spaces let users switch between Home and All Rooms behaviours ([\element-hq#6497](matrix-org/matrix-react-sdk#6497)). Fixes element-hq#18093.
* Support for MSC2285 (hidden read receipts) ([\element-hq#6390](matrix-org/matrix-react-sdk#6390)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Group pinned message events with MELS ([\element-hq#6349](matrix-org/matrix-react-sdk#6349)). Fixes element-hq#17938. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make version copiable ([\element-hq#6227](matrix-org/matrix-react-sdk#6227)). Fixes element-hq#17603 and element-hq#18329. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve voice messages uploading state ([\element-hq#6530](matrix-org/matrix-react-sdk#6530)). Fixes element-hq#18226 and element-hq#18224.
* Add surround with feature ([\element-hq#5510](matrix-org/matrix-react-sdk#5510)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve call event tile wording ([\element-hq#6545](matrix-org/matrix-react-sdk#6545)). Fixes element-hq#18376. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show an avatar/a turned off microphone icon for muted users ([\element-hq#6486](matrix-org/matrix-react-sdk#6486)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Prompt user to leave rooms/subspaces in a space when leaving space ([\element-hq#6424](matrix-org/matrix-react-sdk#6424)). Fixes element-hq#18071.
* Add support for screen sharing in 1:1 calls ([\element-hq#5992](matrix-org/matrix-react-sdk#5992)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Dismiss electron download toast when clicking Open ([\element-hq#18267](element-hq#18267)). Fixes element-hq#18266.
* [Release] Fix glare related regressions ([\element-hq#6622](matrix-org/matrix-react-sdk#6622)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix PiP of held calls ([\element-hq#6612](matrix-org/matrix-react-sdk#6612)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix toast colors ([\element-hq#6607](matrix-org/matrix-react-sdk#6607)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix [object Object] in Widget Permissions ([\element-hq#6560](matrix-org/matrix-react-sdk#6560)). Fixes element-hq#18384. Contributed by [Palid](https://github.com/Palid).
* Fix right margin for events on IRC layout ([\element-hq#6542](matrix-org/matrix-react-sdk#6542)). Fixes element-hq#18354.
* Mirror only usermedia feeds ([\element-hq#6512](matrix-org/matrix-react-sdk#6512)). Fixes element-hq#5633. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix LogoutDialog warning + TypeScript migration ([\element-hq#6533](matrix-org/matrix-react-sdk#6533)).
* Fix the wrong font being used in the room topic field ([\element-hq#6527](matrix-org/matrix-react-sdk#6527)). Fixes element-hq#18339. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix inconsistent styling for links on hover ([\element-hq#6513](matrix-org/matrix-react-sdk#6513)). Contributed by [janogarcia](https://github.com/janogarcia).
* Fix incorrect height for encoded placeholder images ([\element-hq#6514](matrix-org/matrix-react-sdk#6514)). Contributed by [Palid](https://github.com/Palid).
* Fix call events layout for message bubble ([\element-hq#6465](matrix-org/matrix-react-sdk#6465)). Fixes element-hq#18144.
* Improve subspaces and some utilities around room/space creation ([\element-hq#6458](matrix-org/matrix-react-sdk#6458)). Fixes element-hq#18090 element-hq#18091 and element-hq#17256.
* Restore pointer cursor for SenderProfile in message bubbles ([\element-hq#6501](matrix-org/matrix-react-sdk#6501)). Fixes element-hq#18249.
* Fix issues with the Call View ([\element-hq#6472](matrix-org/matrix-react-sdk#6472)). Fixes element-hq#18221. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Align event list summary read receipts when using message bubbles ([\element-hq#6500](matrix-org/matrix-react-sdk#6500)). Fixes element-hq#18143.
* Better positioning for unbubbled events in timeline ([\element-hq#6477](matrix-org/matrix-react-sdk#6477)). Fixes element-hq#18132.
* Realign reactions row with messages in modern layout ([\element-hq#6491](matrix-org/matrix-react-sdk#6491)). Fixes element-hq#18118. Contributed by [robintown](https://github.com/robintown).
* Fix CreateRoomDialog exploding when making public room outside of a space ([\element-hq#6492](matrix-org/matrix-react-sdk#6492)). Fixes element-hq#18275.
* Fix call crashing because `element` was undefined ([\element-hq#6488](matrix-org/matrix-react-sdk#6488)). Fixes element-hq#18270. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Upscale thumbnails to the container size ([\element-hq#6589](matrix-org/matrix-react-sdk#6589)). Fixes element-hq#18307.
* Fix create room dialog in spaces no longer adding to the space ([\element-hq#6587](matrix-org/matrix-react-sdk#6587)). Fixes element-hq#18465.
* Don't show a modal on call reject/user hangup ([\element-hq#6580](matrix-org/matrix-react-sdk#6580)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fade Call View Buttons after `componentDidMount` ([\element-hq#6581](matrix-org/matrix-react-sdk#6581)). Fixes element-hq#18439. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix missing expand button on codeblocks ([\element-hq#6565](matrix-org/matrix-react-sdk#6565)). Fixes element-hq#18388. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* allow customizing the bubble layout colors ([\element-hq#6568](matrix-org/matrix-react-sdk#6568)). Fixes element-hq#18408. Contributed by [benneti](https://github.com/benneti).
* Don't flash "Missed call" when accepting a call ([\element-hq#6567](matrix-org/matrix-react-sdk#6567)). Fixes element-hq#18404. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix clicking whitespaces on replies ([\element-hq#6571](matrix-org/matrix-react-sdk#6571)). Fixes element-hq#18327. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix composer not being disabled when sending voice messages ([\element-hq#6562](matrix-org/matrix-react-sdk#6562)). Fixes element-hq#18413.
* Fix sizing issues of the screen picker ([\element-hq#6498](matrix-org/matrix-react-sdk#6498)). Fixes element-hq#18281. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Stop voice messages that are playing when starting a recording ([\element-hq#6563](matrix-org/matrix-react-sdk#6563)). Fixes element-hq#18410.
* Fix random box appearing when clicking room list headers. ([\element-hq#6561](matrix-org/matrix-react-sdk#6561)). Fixes element-hq#18414.
* Null guard space inviter to prevent the app exploding ([\element-hq#6558](matrix-org/matrix-react-sdk#6558)).
* Make the ringing sound mutable/disablable ([\element-hq#6534](matrix-org/matrix-react-sdk#6534)). Fixes element-hq#15591. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix wrong cursor being used in PiP ([\element-hq#6551](matrix-org/matrix-react-sdk#6551)). Fixes element-hq#18383. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Re-pin Jitsi if the widget already exists ([\element-hq#6226](matrix-org/matrix-react-sdk#6226)). Fixes element-hq#17679. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix broken call notification regression ([\element-hq#6526](matrix-org/matrix-react-sdk#6526)). Fixes element-hq#18335. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* createRoom, only send join rule event if we have a join rule to put in it ([\element-hq#6516](matrix-org/matrix-react-sdk#6516)). Fixes element-hq#18301.
* Fix clicking pills inside replies ([\element-hq#6508](matrix-org/matrix-react-sdk#6508)). Fixes element-hq#18283. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix grecaptcha regression ([\element-hq#6503](matrix-org/matrix-react-sdk#6503)). Fixes element-hq#18284. Contributed by [Palid](https://github.com/Palid).
* Fix compatibility with accounts where the security passphrase was created on a mobile device ([\element-hq#1819](matrix-org/matrix-js-sdk#1819)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants