E2E: Key Backup snagging list

[lampholder]

• 'Start a new backup' should probably indicate that it's a process of regular backups that's being set up, not a one-off backup. (fixed in Move initial key backup to background matrix-org/matrix-react-sdk#2416)
• Escaping the 'Start a new backup' modal is peculiarly difficult - I only managed it by first pressing escape, then clicking outside of the modal (fixed in Fix a few things with cancelling recovery reminder matrix-org/matrix-react-sdk#2420)
• Debounce the feedback text on the passphrase entry
• Niggle: stop telling my passphrase doesn't match before I've obviously finished typing it in
• Niggle: could the 'go back and set it again' link be a backwards-directing button on the modal?
• Niggle: the 'backup version' is not something we'd expect everyday users to understand or care about - in the final impl could this be downplayed?
• "This device is uploading keys to this backup" (in user settings) sounds like it's in the process of doing it right now' so does "Your encryption keys are now being backed up to your Homeserver." (on the success dialogue after setting up backup) (fixed in Move initial key backup to background matrix-org/matrix-react-sdk#2416)
• It's too easy to to dismiss the key backup nag bar forever (and never again be reminded of something you really should do)
• It looks like we set 'showRoomRecoveryReminder' to false if the user sets up backup (rather than to record a permanent dismissal of the reminder). (fixed in Fix a few things with cancelling recovery reminder matrix-org/matrix-react-sdk#2420)
• If you mash in a wrong key, the title of the modal is still 'Backup Restored'. And it gives you a total of the failures (rather than suggesting you check your password).
• We should consider referring to the initial upload as an initial upload to reinforce the idea that you'll keep backing up to this backup automatically (fixed in Move initial key backup to background matrix-org/matrix-react-sdk#2416)

EDIT: Extracting "The Secure Message Recovery notif should say if you already have a backup in place (and that 'setup' means 'just verify the device that started the backup' in that case)" to a separate issue 'cause it unlocks our ability to turn this feature on by default for /develop and /experimental users

[lampholder]

• Set up backup notification doesn't play nicely with widgets:
  

[jryans]

It looks like we set 'showRoomRecoveryReminder' to false if the user sets up backup (rather than to record a permanent dismissal of the reminder).

Do you have more detail about this one? In my testing, setting up the backup does not change showRoomRecoveryReminder to false. The intent of the current code is exactly as you describe: only opting out should cause this setting to change.

[dbkr]

Found this one - it's if you hit the 'x' button on the dialog at the end of the key backup process rather than the 'close' button. I'll fix this now.

[dbkr]

Sensible debouncing behaviour is quite subtle here, eg. if I type a crap password then add the '1' on the end, does it continue to tell me its crap for 0.5s or does that change happen straight away? The easiest might be for it to hide the feedback altogether while the user is 'still typing', but this may also feel weird.

I think our only precedent here is checking on the onblur handler which wouldn't work here as there's only one field so it would be essentially equivalent to validating on 'Next'.

[lampholder]

Only niggles and the warning vs widgets issue remain, so I've pulled warning vs widgets out to a separate bug: #9078