Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: confusion of lab flags for invisible crypto #3319

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

BillCarsonFr
Copy link
Member

Pull Request Checklist

Fixes #3310

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@BillCarsonFr BillCarsonFr added the pr-bugfix for bug fix label Sep 23, 2024
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner September 23, 2024 15:10
@BillCarsonFr BillCarsonFr requested review from Velin92 and pixlwave and removed request for a team September 23, 2024 15:10
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against 3f59377

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I missed this in review! 😳

@Velin92 Velin92 enabled auto-merge (squash) September 23, 2024 15:13
Copy link

sonarcloud bot commented Sep 23, 2024

@BillCarsonFr
Copy link
Member Author

BillCarsonFr commented Sep 23, 2024

Ah, sorry I missed this in review! 😳

I think it was after the requested change to rename the param and directly pass the flag.
I did not ran all the manual test again in my synapse :/

Copy link

codecov bot commented Sep 23, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
824 1 823 0
View the full list of 1 ❄️ flaky tests
CompletionSuggestionServiceTests testUserSuggestionsWithEmptyText()

Flake rate in main: 12.82% (Passed 68 times, Failed 10 times)

Stack Traces | 20.7s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit 69009a8 into develop Sep 23, 2024
13 checks passed
@pixlwave pixlwave deleted the valere/fix_flag_wrongly_enabled branch September 23, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken messaging with e2be (mautrix) bridges (potential fix included)
3 participants