Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug on iOS 18 where the timeline background would use the wrong colour scheme when using the app switcher. #3324

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 24, 2024

Use the UIColors directly instead of wrapping the SwiftUI Colors.

Before After
before after

@pixlwave pixlwave requested a review from a team as a code owner September 24, 2024 10:27
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 24, 2024 10:27
@pixlwave pixlwave added the pr-bugfix for bug fix label Sep 24, 2024
@pixlwave pixlwave changed the title Use the UIColors directly instead of wrapping the SwiftUI Colors. Fix a bug on iOS 18 where the timeline background would use the wrong colour scheme when using the app switcher. Sep 24, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 80685b7

Comment on lines +63 to +68
compound_color_conversion:
regex: "UIColor\\(\\.compound"
match_kinds: identifier
message: "Please use the UIColor token directly to ensure the colour scheme is honoured."
severity: warning

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suuuper nice 👌

Copy link

codecov bot commented Sep 24, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
824 2 822 0
View the top 2 failed tests by shortest run time
PreviewTests test_joinRoomScreen()
Stack Traces | 9.42s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-pseudo.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-pseudo.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9593811 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:66)
PreviewTests test_timelineItemBubbledStylerView()
Stack Traces | 16.5s run time
failed - Snapshot "Pinned messages" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineItemBubbledStylerView-iPad-en-GB.Pinned-messages.png"
@+
"file:.../tmp/PreviewTests/test_timelineItemBubbledStylerView-iPad-en-GB.Pinned-messages.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.99940014 is less than required 1.0
The lowest perceptual color precision 0.7782813 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:66)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave
Copy link
Member Author

Same on the tests as #3323, they're being flakey on CI.

@pixlwave pixlwave merged commit c264e9e into develop Sep 24, 2024
7 of 8 checks passed
@pixlwave pixlwave deleted the doug/fix-timeline-background branch September 24, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants