allow disabling elementary version check #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checking the version is nice and all, but when running in production it just creates firewall log spam - we don't let traffic out anywhere, everything is explicitly allowed in kubernetes overlay network policy as well as an overarching firewall policy. Everytime elementary runs we see the spam trying to contact pypi to check for a newer version. This PR creates a simple config to allow disabling the check.
slaupster
changed the title
|
Thanks a lot for this contribution, makes a lot of sense! |
elongl
reviewed
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checking the version is nice and all, but when running in production it just creates firewall log spam - we don't let traffic out anywhere, everything is explicitly allowed in kubernetes overlay network policy as well as an overarching firewall policy. Everytime elementary runs we see the spam trying to contact pypi to check for a newer version.
This PR creates a simple config to allow disabling the check.