Inheriting ephemeral models' deps for lineage. #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @elongl |
elongl
force-pushed
the
ele-3555-model-ephemeral-models-in-lineage
branch
3 times, most recently
from
97b6263
to
84da0c7
Compare
haritamar
reviewed
Aug 20, 2024
| json.loads(dep_node["depends_on_nodes"]) | ||
| if dep_node["depends_on_nodes"] | ||
| else [] | ||
| ) |
There was a problem hiding this comment.
This doesn't handle the case where dep_node["depends_on_nodes"] by itself contains ephemeral nodes.
Something I can suggest (other than making this function recursive) is to first sort by dependencies (toposort is a good library) and then handle nodes in reverse order.
There was a problem hiding this comment.
Also - new_dep_ids may contain duplicates, probably better to make it a set
elongl
force-pushed
the
ele-3555-model-ephemeral-models-in-lineage
branch
2 times, most recently
from
24f2b3d
to
92d88bf
Compare
elongl
force-pushed
the
ele-3555-model-ephemeral-models-in-lineage
branch
from
92d88bf
to
55d9196
Compare
haritamar
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.