Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure subcollections use TransactionRepository inside transactions #42

Conversation

elersong
Copy link
Owner

@elersong elersong commented Jul 15, 2024

It appears that the reported problem has already been resolved, according to jest. So this PR includes a test to prove that.

No api changes required

@elersong elersong self-assigned this Jul 15, 2024
@elersong elersong linked an issue Jul 15, 2024 that may be closed by this pull request
@elersong elersong force-pushed the 37-ensure-subcollections-use-transactionrepositories-inside-transactions branch from 2c5cb9f to 1c5eeab Compare July 15, 2024 21:43
Copy link

sonarcloud bot commented Jul 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@elersong elersong merged commit f9abf1a into master Jul 15, 2024
3 of 4 checks passed
@elersong elersong deleted the 37-ensure-subcollections-use-transactionrepositories-inside-transactions branch July 15, 2024 21:54
@elersong
Copy link
Owner Author

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Subcollections Use TransactionRepositories Inside Transactions
1 participant