Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(32): support multiple subcollections of the same type #45

Merged
merged 39 commits into from
Jul 25, 2024

Conversation

elersong
Copy link
Owner

  • Add a name identifier to all collections and subcollections.
    • All collections have the same base interface. Subcollections have additional data for indexing.
  • Change the way collections/repositories are stored/fetched.
  • Update other classes to interact to new Metadata interactions.

@elersong elersong added the enhancement New feature or request label Jul 21, 2024
@elersong elersong self-assigned this Jul 21, 2024
@elersong elersong linked an issue Jul 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 90.71038% with 17 lines in your changes missing coverage. Please review.

Project coverage is 93.52%. Comparing base (a633339) to head (f39657d).
Report is 6 commits behind head on master.

Files Patch % Lines
src/helpers.ts 73.68% 10 Missing ⚠️
src/Errors/index.ts 88.46% 3 Missing ⚠️
src/Decorators/SubCollection.ts 81.81% 2 Missing ⚠️
src/AbstractFirestoreRepository.ts 88.88% 1 Missing ⚠️
src/utils.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   94.81%   93.52%   -1.30%     
==========================================
  Files          26       27       +1     
  Lines         656      772     +116     
  Branches      107      149      +42     
==========================================
+ Hits          622      722     +100     
- Misses         33       49      +16     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elersong elersong force-pushed the 32-support-multiple-subcollections-of-the-same-type branch from f39657d to dba485e Compare July 23, 2024 23:28
Copy link

sonarcloud bot commented Jul 25, 2024

@elersong elersong merged commit 2b1cdd1 into master Jul 25, 2024
4 checks passed
@elersong
Copy link
Owner Author

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Multiple SubCollections of the Same Type
1 participant