Revert interface change. #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added a commit
to chrahunt/TagProReplays
that referenced
this pull request
Mar 20, 2018
We use a branch that has a fixed version of FileSaver.js until eligrey/FileSaver.js#411 gets merged. Fixes #216.
chrahunt
added a commit
to chrahunt/TagProReplays
that referenced
this pull request
Mar 20, 2018
* Update FileSaver to fix Chrome download issue. We use a branch that has a fixed version of FileSaver.js until eligrey/FileSaver.js#411 gets merged. Fixes #216. * Fix Travis build. Per travis-ci/travis-ci#8836, their container infrastructure does not support sandboxed Chrome. We don't want to switch to `sudo: required` (for speed) so we use `no-sandbox` as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the comments on dfd5856, switching to using
defaultis a breaking change and should be reserved for a major version increment. The syntax was invalid anyways, resulting in build failures. This is likely what caused the empty package in Bower.Fixes #407, #409 (assuming someone with permissions follows through and builds/uploads).