Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): hide account lock icon on status card in timeline #2772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Apr 6, 2024

fix #2492

As explained in the original issue, showing the account lock 🔒 icon on the status card is quite confusing:

Screenshot from 2024-04-06 01-40-26

I think this decision in the official Mastodon UI is reasonable because the meaning of 🔒 icon on Mastodon differs from that on Twitter.

On Twitter, 🔒 icon for the account has two meanings at the same time: the account requires to follow requests, and the visibility of all the posts is limited to "Only follower". So showing 🔒 icon on the status makes sense.

On the other hand, on Mastodon, the visibility of posts and account following limitations are separated. And the locked account still can publish publicly visible posts so 🔒 icon only indicates that the following approval is required when someone is following.

Mastodon already has the icon for visibility on the post (such as 🌎 and 🔒) so it should be enough to show 🔒 icon only on the account page (or other account-specific component) where users need to know whether the account requires the following request or not.

Although Mastodon UI doesn't show the bot icon too, I think we can keep it because the bot icon can show both meanings: the account is automated and the post itself is programmatically published by the bot.

After

image

The status detail page still shows the lock indicator as the visibility indicator is clearly separated in different places without confusion.

Screenshot from 2024-04-06 17-24-40

Another example with the lock icon:

image

Copy link

stackblitz bot commented Apr 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 6fec751
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/66110597a451550008ff40b1

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 6fec751
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/66110597023cb100088fda4c
😎 Deploy Preview https://deploy-preview-2772--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3 shuuji3 force-pushed the shuuji3/fix/hide-account-lock-icon-in-status-card branch from 48e0676 to 6fec751 Compare April 6, 2024 08:19
@shuuji3 shuuji3 changed the title fix(ui): hide account lock icon in status card fix(ui): hide account lock icon on status card in timeline Apr 6, 2024
@ayoayco
Copy link
Member

ayoayco commented Aug 10, 2024

To me it's more about the position of the icon. I think if the lock is for the account it should be visible & closer to the name/profile picture. Then maybe we can also show consistently in different profile views?

I wonder if we could have two rows in the status card similar as in the profile page...

the name + icons (at top) and username (bottom)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Own public toots are shown as "only follower"
2 participants