Skip to content

Commit

Permalink
Fix NoneType bug & fill the test recipients with original recipients …
Browse files Browse the repository at this point in the history
…if empty (apache#7365)
  • Loading branch information
tssujt authored and mistercrunch committed Apr 25, 2019
1 parent 929fb6b commit 4fe152d
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions superset/views/schedules.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,12 @@ class EmailScheduleView(SupersetModelView, DeleteMixin):
edit_form_extra_fields = add_form_extra_fields

def process_form(self, form, is_created):
recipients = form.test_email_recipients.data.strip() or None
if form.test_email_recipients.data:
test_email_recipients = form.test_email_recipients.data.strip()
else:
test_email_recipients = None
self._extra_data['test_email'] = form.test_email.data
self._extra_data['test_email_recipients'] = recipients
self._extra_data['test_email_recipients'] = test_email_recipients

def pre_add(self, obj):
try:
Expand All @@ -111,7 +114,7 @@ def pre_update(self, obj):
def post_add(self, obj):
# Schedule a test mail if the user requested for it.
if self._extra_data['test_email']:
recipients = self._extra_data['test_email_recipients']
recipients = self._extra_data['test_email_recipients'] or obj.recipients
args = (self.schedule_type, obj.id)
kwargs = dict(recipients=recipients)
schedule_email_report.apply_async(args=args, kwargs=kwargs)
Expand Down

0 comments on commit 4fe152d

Please sign in to comment.