Add fieldset for GCCFG register variant on devices with USB core ID 5000 #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some devices, such as the U5 and H7R/S series, the
GCCFGregister of theOTG_HSperipheral does not match the existing definitions (cp. RM0477 sec. 62.14.18 and RM0456 sec. 73.14.18). They all have the USB core ID5000.These changes are necessary to implement support for the peripheral on the H7R/S in embassy-rs/embassy#3289. #519 may also be related, although there seem to be some additional changes necessary to get USB to work on those U5 parts.