This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Add support for building SSE2 code to JS. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return (caps ? (isInt ? "Int" : "Float") : (isInt ? "int" : "float")) + std::to_string(primSize) + 'x' + std::to_string(numElems); | ||
| } | ||
|
|
||
| std::string WrapMathFRound(const std::string &value, bool wrap) { |
There was a problem hiding this comment.
this is similar to ensureFloat. First of all, the name should begin with a lowercase letter. Second, how about also calling it ensureFloat, but overloaded with a second parameter which is a bool? And implementing it right after ensureFloat?
|
Aside from one comment above, this looks good. I am not familiar with the SIMD correctness wrt the spec, though, perhaps @sunfishcode wants to review that aspect. |
|
Thanks, renamed the function. Also did other changes to help SSE2 code generation in emscripten-core/emscripten#3542 |
…e instead of a shuffle.
… the output can avoid emitting redundant SIMD symbols.
|
Ping @sunfishcode , this is now ready to be reviewed and merged from my end. Merging this should be done at the same time with emscripten-core/emscripten#3542, since they go hand in hand. |
sunfishcode
added a commit
that referenced
this pull request
Aug 20, 2015
Add support for building SSE2 code to JS.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.