WRR-626: Updated puppeteer and wait-on dependencies to latest version #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-stoian-lgp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Puppeteer needed upgrade to the latest version
wait-on needed upgrade to the latest version
Resolution
changelog for puppeteer-core: https://github.com/puppeteer/puppeteer/blob/main/packages/puppeteer-core/CHANGELOG.md
Updated puppeteer dependencies to latest version
Unfortunately, "ws" subdependency had to be pinned to an older version in order for the tests to work. This means that the security vulnerabilities could not be solved by this PR
Fot wait-on, there were no breaking changes affecting us https://github.com/jeffbski/wait-on/releases
Additional Considerations
executablePathis required to be added since puppteer19headless:truewas required because of this breaking change puppeteer/puppeteer#11815jsdon-extended.js file was added because of a conflict between jsdom and new ReadableStreams introduced in puppeteer 22 puppeteer/puppeteer#11805 . Solution could be found here: mswjs/msw#1916 (comment)
Links
WRR-626
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)