-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'sni_hostname' extension with SOCKS proxy. #772
Comments
Thanks for this, I'll retitle it so that it's more specific. |
tomchristie
changed the title
Inconsistent update, regarding sni_hostname extension.
Support 'sni_hostname' extension with SOCKS proxy.
Aug 8, 2023
@Allgot Would you like to issue a pull request resolving this? |
@tomchristie But since this is my first contribution to this repository(in terms of pull requests), my request might not be perfect. It would be great if you can correct errors, if exist :) |
I've send a PR. Please refer to #774 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, there is an issue with
sni_hostname
not functioning correctly when the connection involves a socks proxy.This problem arises due to the oversight in commit #696, where the update to
_sync/socks_proxy.py
and_async/socks_proxy.py
was omitted.Code for reproduction (written by @karosis88 at #771)
Set up proxy server (defaults to 1080 port)
Client
Expected output
Actual output
Suggested fix
Update the
_sync/socks_proxy.py
and_async/socks_proxy.py
in a manner similar to that of the_sync/connection.py
and_async/connection.py
.Example fix for
_async/socks_proxy.py
:The text was updated successfully, but these errors were encountered: