Add sni hostname extension #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karpetrosyan
force-pushed
the
add-sni-hostname-extension
branch
from
1e4d1c9
to
dfc30a9
Compare
…sni-hostname-extension
|
Should we alert the client if they attempt to use HTTPS without specifying "socket_options" extension? |
tomchristie
reviewed
May 22, 2023
…pcore into add-sni-hostname-extension
tomchristie
requested changes
May 22, 2023
tomchristie
approved these changes
May 22, 2023
tomchristie
requested changes
May 22, 2023
CHANGELOG.md
Outdated
| @@ -9,6 +9,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| - Improve logging with per-module logger names. (#690) | |||
| - Resolve race condition during import of `anyio` package. (#692) | |||
| - Enable TCP_NODELAY for all synchronous sockets. (#651) | |||
| - Add `socket_options` argument to `ConnectionPool` and `HTTProxy` classes. (#668) | |||
There was a problem hiding this comment.
Just noticed this isn't in the correct pull request.
|
Sorry my bad 🥲 |
tomchristie
approved these changes
May 22, 2023
Merged
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #691