Version 0.17.1

[Pliner]

Hi @tomchristie,

It is a PR for a new release, based on #661 and #640 as examples.

I am not sure whether any checklist is needed: 1) #669, #678 and #679 have already been merged 2) The date has been filled in.

Also, I am not able to create a draft of GH release, but I hope it is not a problem.

[tomchristie]

Great, thanks!

The bullet points here are describing implementation changes, rather than the (user-facing) behaviour.
First up, let's see how we can describe each of those 3 changes properly...

• Retry ConnectError/ConnectTimeout happened in stream.start_tls #669 Retry ConnectError/ConnectTimeout happened in stream.start_tls. - This isn't too bad a description, but perhaps "If 'retries' is set, then allow retries if an SSL handshake error occurs."
• Chain exception re-raise in map_exceptions #678 - Could be "Improve correctness of tracebacks on network exceptions, by raising properly chained exceptions."
• Add check for h2.connection.ConnectionState.CLOSED in AsyncHTTP2Connection.is_available #679 - Could be "Prevent connection-hanging behaviour when HTTP/2 connections are closed by a server-sent 'GoAway' frame".

(What do you think?)

This also prompts a suggested procedure improvement... we should start ensuring that pull requests update the release notes.
That will ensure that PR authorship is driven by describing behavioural changes rather than implementation changes, and will make the release process easier.

[tomchristie]

I think we should also pull in #680, resolving #670 into this release.

How do we describe this? "Fix edge-case exception when removing requests from the connection pool." perhaps? It's not great, but it'd probably do.

[tomchristie]

Okay, here's a release draft based on your CHANGELOG here...

https://github.com/encode/httpcore/releases/tag/untagged-b7d3a9dd34c002f475be

Does this all look correct?

[Pliner]

@tomchristie Thanks for your suggestions regarding changelog. Unfortunately, I cannot access https://github.com/encode/httpcore/releases/tag/untagged-b7d3a9dd34c002f475be, probably it is accessible only for maintainers.

PS Sorry for the delayed reply, I prepared a reply right after my last commit, but forgot to press comment button 😞

[tomchristie]

Looks good, let's go on this.

(Also, I've sent you an invite to @encode/maintainers which you're welcome to either accept or decline.)

[Pliner]

Looks good, let's go on this.

(Also, I've sent you an invite to @encode/maintainers which you're welcome to either accept or decline.)

Cool, thanks!

[Pliner]

@tomchristie Just to double check: could I publish https://github.com/encode/httpcore/releases/tag/untagged-b7d3a9dd34c002f475be (it looks like now I have enough permissions for this), or are you going to do it by yourself later on?

I looked at it, and it looks good.

[tomchristie]

@Pliner so... let's also get #688 added in.

Once that's done, we can talk through publishing the release.
(The more folks who get to work through the process, the better.)

[Pliner]

@Pliner so... let's also get #688 added in.

Once that's done, we can talk through publishing the release. (The more folks who get to work through the process, the better.)

I've added #688 to https://github.com/encode/httpcore/releases/tag/untagged-4c24a8601913f6ed346b

[tomchristie]

Okay, you're welcome to hit "publish" on the release if you'd like.

I'll show how the workflow proceeds after that.

[Pliner]

Okay, you're welcome to hit "publish" on the release if you'd like.

I'll show how the workflow proceeds after that.

Thanks, done!

[tomchristie]

Great, so...

Our publish workflow: https://github.com/encode/httpcore/actions/runs/5005203672

Has initiated this action: https://github.com/encode/httpcore/actions/runs/5005203672

Once someone from the @encode/operations team approves that action (which I've just done), the action runs, and should deploy the release to PyPI.

We should probably create an issue for a docs page or repository markdown document describing the contribution and release processes.