-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.14.1 #1088
Version 0.14.1 #1088
Conversation
OK, this will actually have to wait till tomorrow unless somebody want to take it over. 😴 🛌 |
Looks fine to me. I'd probably include a link in the changelog to the documentation that teaches people how to build their own? |
Changes, think they need re-review.
|
||
### Removed | ||
|
||
* `UJSONResponse` was removed (this change was intended to be included in 0.14.0). Please see the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional hint is nice; could we please still add the PR number, for the sake of traceability? (This is what I meant in my last suggestion adding Pull #N
. I find they make it easier to find back the set of changes and provide an additional way to evaluate what actually changed.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Was going for brevity/similarity to previous changelog entries, but will rather go for (succinct) detail in the future 👍.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for doing it.
Removed
UJSONResponse
was removed (this change was intended to be included in 0.14.0).