Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Mount work like before #2364

Closed
wants to merge 1 commit into from
Closed

Make Mount work like before #2364

wants to merge 1 commit into from

Conversation

abersheeran
Copy link
Member

Summary

This should solve #2361

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@abersheeran abersheeran added the hold Don't merge it label Dec 7, 2023
@Kludex
Copy link
Sponsor Member

Kludex commented Dec 16, 2023

What do you want to do here @abersheeran ?

@abersheeran
Copy link
Member Author

django/asgiref#424 I want to wait for the final result of this discussion before deciding how to do this PR.

@Kludex Kludex deleted the keep-mount-work branch December 17, 2023 07:04
@tarsil
Copy link
Contributor

tarsil commented Dec 18, 2023

@abersheeran I can see here and the django/asgiref#424 are closed. What are the conclusions to make the Mount work as before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hold Don't merge it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abersheeran @Kludex @tarsil