♻️ Refactor logic to handle root_path to keep compatibility with ASGI and compatibility with other non-Starlette-specific libraries like a2wsgi
#2400
+90
−37
Commits on Jan 7, 2024
-
-
♻️ Refactor extracting the local route_path from the scope, and creat…
…ing the child scope with its own root_pat, this allows sub-apps (e.g. WSGIMiddleware) to know where it was mounted, and from which path prefix starts the path its sub-app should handle
-
♻️ Refactor datastructures and request to be conformant with the ASGI…
… spec, respecting root_path
-
✅ Add and update tests for root_path with mounted apps that don't kno…
…w about Starlette internals (e.g. the route_root_path extension scope key that was added in
-
✅ Update test for root_path, TestClient was not requiring paths under…
… a root_path to pass the root_path, which is what clients would have to do if the app is mounted.
-
-
-
Commits on Jan 8, 2024
-
-
✨ Update (deprecated) WSGIMiddleware to be compatible with the update…
…d root_path, taking pieces from a2wsgi
-
-
Commits on Jan 9, 2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.