Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added route value to scope #804

Closed
wants to merge 4 commits into from
Closed

Added route value to scope #804

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b7d2d5
Added route value to scope
victoraugustolls Jan 16, 2020
5dc3170
Added matched routes to scope
victoraugustolls Jan 29, 2020
61f0f72
Updating routing format
victoraugustolls Feb 24, 2020
fd359c1
Merge branch 'master' into feature/route_value
victoraugustolls Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion starlette/routing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,12 @@ def matches(self, scope: Scope) -> typing.Tuple[Match, Scope]:
matched_params[key] = self.param_convertors[key].convert(value)
path_params = dict(scope.get("path_params", {}))
path_params.update(matched_params)
child_scope = {"endpoint": self.endpoint, "path_params": path_params}
child_scope = {
"endpoint": self.endpoint,
"path_params": path_params,
"route": self.path,
victoraugustolls marked this conversation as resolved.
Show resolved Hide resolved
"name": self.name,
}
if self.methods and scope["method"] not in self.methods:
return Match.PARTIAL, child_scope
else:
Expand Down