missing headers (using Fastify)

[kireerik]

We are using @fastify/ cors and cookies and the headers are missing when using this library.

If I change this line (

graphql-sse/src/use/fastify.ts

Line 90 in 061b0fc

reply.raw.writeHead(init.status, init.statusText, init.headers);

) like this (

    reply.raw.writeHead(init.status, init.statusText, {...reply.getHeaders(), ...init.headers});

) then the cors headers are not missing, but the cookie header is still missing.

[enisdenjo]

Hey there, the Cookie header does not come from the server - it comes only from the client (see MDN).

However, a server can send a Set-Cookie header though. Can you try that?

Regarding the rest of the headers, a PR is very welcome - would you consider opening one? Thanks in advance!

[kireerik]

Hi, yes, that's what is not working as well. We are using @fastify/cookie to set a cookie from the server side using Set-Cookie.

Sure, I can for sure create a pull request for the cors case. However the missing Set-Cookie header is a bit unclear for me. I am not sure how should I get it. We set the cookie from a (GraphQL) (mutation) resolver (using @fastify/cookie).

[enisdenjo]

Is the set-cookie header present without graphql-sse? Maybe it is not in the getHeaders (you can check that by console logging the results)?

[kireerik]

Yes, it is. Yes it is not in the getHeaders.

Anyway. Now we are using the GraphQL Yoga server which (after resolving 2 issues related to it) seems to work as expected.

related issue:

• Router not working with specific url.  fastify/help#103

[enisdenjo]

🎉 This issue has been resolved in version 2.5.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[enisdenjo]

Sorry for waiting so long! This issue has been fixed with 134c1b0 and released in v2.5.3. Please check it out, thanks!