Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change currency units #901

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Change currency units #901

merged 4 commits into from
Jun 21, 2024

Conversation

JesseAbram
Copy link
Member

@JesseAbram JesseAbram commented Jun 20, 2024

Changes currency units to match Polkadot's (which we decided 10 decimals so this should have been changed with that) of note turns existential deposit down to 0.01

Closes #888

@JesseAbram JesseAbram marked this pull request as ready for review June 20, 2024 19:05
Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but on my end PJS still shows that we have 12 decimals

image

Not entirely sure why though, maybe outdated metadata somewhere 🤷 ?

Also, I wonder if this requires a spec_version bump or something 🤔

@JesseAbram
Copy link
Member Author

Code looks fine, but on my end PJS still shows that we have 12 decimals

image Not entirely sure why though, maybe outdated metadata somewhere 🤷 ?

Also, I wonder if this requires a spec_version bump or something 🤔
maybe but we def have a spec bump in the next release so let's not overthink it

image

fixed it, we were not adding the properties to the dev chainspec

@JesseAbram JesseAbram merged commit ca4ad1a into master Jun 21, 2024
13 checks passed
@JesseAbram JesseAbram deleted the Change-currency-units branch June 21, 2024 18:04
@HCastano HCastano added Bump `spec_version` A change which affects the current runtime behaviour Bump `transaction_version` A change which affects how existing extrinsics are created (e.g parameter changes) labels Jun 24, 2024
HCastano added a commit that referenced this pull request Jun 26, 2024
These broke after the ED changes from #901. I haven't been able to solve this in a satisfactory way,
so in order to keep the `v0.2.0` release pipeline moving I suggest we ignore this for now and
investigate later.

See #914 for more details.
HCastano added a commit that referenced this pull request Jun 26, 2024
These broke after the ED changes from #901. I haven't been able to solve this in a satisfactory way,
so in order to keep the `v0.2.0` release pipeline moving I suggest we ignore this for now and
investigate later.

See #914 for more details.
HCastano added a commit that referenced this pull request Jul 11, 2024
HCastano added a commit that referenced this pull request Jul 11, 2024
* Bump crate versions to `v0.2.0`

* Add #901 to the breaking changes list

* Update `CHANGELOG` to use full release instead of `rc`

* TaploFmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump `spec_version` A change which affects the current runtime behaviour Bump `transaction_version` A change which affects how existing extrinsics are created (e.g parameter changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Existential Deposit
3 participants