Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bugfixes revealed while preparing for conda release #2

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Minor bugfixes revealed while preparing for conda release #2

wants to merge 4 commits into from

Conversation

elinscott
Copy link
Collaborator

@elinscott elinscott commented Sep 22, 2022 •
edited

  • various minor tweaks to the cmake configuration
  • renamed epsilon.x -> epsilon_koopmans.x to avoid a nameclash if q-e is already installed

@elinscott elinscott self-assigned this Sep 22, 2022
@elinscott elinscott marked this pull request as ready for review September 23, 2022 15:55
@degennar
Copy link
Collaborator

The standard compilation with make works fine, but cmake fails.
I am attaching the content of CMakeError.log.
CMakeError.log

@elinscott elinscott marked this pull request as draft October 5, 2022 15:45
@elinscott
Copy link
Collaborator Author

Putting this PR on hold for the moment while we explore instead migrating the contents of koopmans-qe-utils to koopmans-kcp and q-e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degennar degennar Awaiting requested review from degennar

At least 1 approving review is required to merge this pull request.

Assignees

@elinscott elinscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elinscott @degennar