fix: interrupt as soon as we retry #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume we start the run with two PRs in an unknown state.
As soon as we schedule a retry we can interrupt the loop. It is redundant. Even worse: Every retry queries all PRs which leads to exponential growth in retries.
Since it's very likely that subsequent PRs are also in an unknown state we can stop looping. We'll revisit them in the retry anyway.
Also makes
checkDirtyside-effect free.mainis now responsible for setting the output which ensures we're not setting it multiple times.