Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: some equinix_fabric_connection using deprecated equinix_ecx_l2_connection fields #777

Open
ocobles opened this issue Sep 16, 2024 · 0 comments · May be fixed by #780
Open

[Docs]: some equinix_fabric_connection using deprecated equinix_ecx_l2_connection fields #777

ocobles opened this issue Sep 16, 2024 · 0 comments · May be fixed by #780

Comments

@ocobles
Copy link
Contributor

ocobles commented Sep 16, 2024

I found at least three examples using resource equinix_fabric_connection that replaced equinix_ecx_l2_connection but without updating the fields, so now most of those fields are different

resource "equinix_fabric_connection" "example" {
name = "tf-port-to-metal-legacy"
speed = "200"
speed_unit = "MB"
notifications = ["example@equinix.com"]
port_uuid = data.equinix_fabric_port.example.id
vlan_stag = 1020
authorization_key = equinix_metal_connection.example.token
}

resource "equinix_fabric_connection" "example" {
name = "tf-port-to-metal"
zside_service_token = equinix_metal_connection.example.service_tokens.0.id
speed = "200"
speed_unit = "MB"
notifications = ["example@equinix.com"]
port_uuid = data.equinix_fabric_port.example.id
vlan_stag = 1020
}

resource "equinix_fabric_connection" "example" {
name = "tf-metal-to-azure"
profile_uuid = data.equinix_fabric_sellerprofile.example.uuid
speed = azurerm_express_route_circuit.example.bandwidth_in_mbps
speed_unit = "MB"
notifications = ["example@equinix.com"]
service_token = equinix_metal_connection.example.service_tokens.0.id
seller_metro_code = "AM"
authorization_key = azurerm_express_route_circuit.example.service_key
named_tag = "PRIVATE"
secondary_connection {
name = "tf-metal-to-azure-sec"
service_token = equinix_metal_connection.example.service_tokens.1.id
}
}

@ocobles ocobles changed the title docs: some equinix_fabric_connection using deprecated equinix_ecx_l2_connection fields [Docs]: some equinix_fabric_connection using deprecated equinix_ecx_l2_connection fields Sep 17, 2024
ocobles added a commit to equinix/pulumi-equinix that referenced this issue Sep 17, 2024
generate examples was failing since some explicitly excluded examples
had been renamed in terraform

"metal_bgp_session/example_1.tf" -->
"equinix_metal_bgp_session/example_1.tf"
"metal_connection/\*" --> "equinix_metal_connection/\*"

I have also removed some manually created equinix_metal_connection
examples, in order to use the ones available in Terraform.
- examples/metal/connection/example_metal_billed
- examples/metal/connection/example_fabric_billed

However, some of them need to be fixed first in terraform
equinix/terraform-provider-equinix#777, those
still specified in the
[EXCLUDE_TF_EXAMPLES](https://github.com/equinix/pulumi-equinix/compare/fix-generate-examples?expand=1#diff-0371a6843acadceb847895dd7de8ae7e51e24f5bb121e9591fb2798cbb7a25b9L5)
list

"equinix_metal_connection/shared_no_token_metal_to_fabric.tf" \
"equinix_metal_connection/shared_token_fabric_port_to_metal.tf" \
"equinix_metal_connection/shared_token_metal_to_csp.tf"

This will fix the issue in
"https://github.com/equinix/pulumi-equinix/actions/runs/10692829858".
Adding also ">&2" in the echo commands to ensure that log messages are
sent to standard error output and we can trace them in the gh action
@ocobles ocobles linked a pull request Sep 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant